From patchwork Wed May 22 23:29:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 245781 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-wg0-x23c.google.com (mail-wg0-x23c.google.com [IPv6:2a00:1450:400c:c00::23c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B4B3E2C0091 for ; Thu, 23 May 2013 09:29:14 +1000 (EST) Received: by mail-wg0-f60.google.com with SMTP id m15sf292853wgh.5 for ; Wed, 22 May 2013 16:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-beenthere:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=Gl99B20L0WyJLRVrI+FGMhPGOwk/eqCZQczTQDEofvk=; b=gBPFiDc7yr2nmhGx4Jxsk5Y50U6rM+39Sbmh2cJyCneXIwkNSDKOiVCLCT/qe0v1H6 G5oPborAhzeFpcvIPPkmJhOGyyNsrIs7KkRGCuj24jg2T8unZfZ05SDCXTIrpp7mYQgl 6RwQ1jYA2xH9/+Z0cUJeHUt096Z8FwWraj+1mHrZMZOBg3sYIumeJX9J1POQ6iEwEwOj bDTvlKUFKzCuac8BIu6/2/9nO66aZ28IJbdpoCF5ogbYbnspucpJBjCi+fow6oVJD7MA /j8oo7n3eAuMx/4l2zJDf628+uuj8cATVaPIBATBgqpx0MNypg89syelAcEMfp0HwRkI YHCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-beenthere:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=Gl99B20L0WyJLRVrI+FGMhPGOwk/eqCZQczTQDEofvk=; b=EmK4Jn/N5uv3PCzqamUbRoO6FTeCpCjzd8hlE56wllgTq6UoP3+4Ru+vNp/FbdXGbV seKCsuiYb2RYXab/9RyZnO0OgNDBd2sNgavRTmoQnAzmNsyQER7HAz0ImEBOXiStB7sk FUtccebb2XjEfX8OyiHviqh4FpamWZMtthtFlPdjbd3pbqqhb6jcwfYTtem+fXLmSxJ6 drd1uhEyh2b4l2uojBAKlXjthrejPAeq59lH9WFTq/qnQJY96YpYDIRC48zIApbLbXNL 6krbacozOR//4SWSbR/PO5NwLhjJUfdLcgdkPoLrekKG5vHPcdB3euuQbsq3/yaowG1n ztrQ== X-Received: by 10.180.185.236 with SMTP id ff12mr404959wic.11.1369265350630; Wed, 22 May 2013 16:29:10 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.89.103 with SMTP id bn7ls693432wib.36.canary; Wed, 22 May 2013 16:29:08 -0700 (PDT) X-Received: by 10.204.228.132 with SMTP id je4mr942892bkb.6.1369265348634; Wed, 22 May 2013 16:29:08 -0700 (PDT) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com [209.85.217.178]) by gmr-mx.google.com with ESMTPS id ev8si874758bkb.1.2013.05.22.16.29.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 May 2013 16:29:08 -0700 (PDT) Received-SPF: pass (google.com: domain of digetx@gmail.com designates 209.85.217.178 as permitted sender) client-ip=209.85.217.178; Received: by mail-lb0-f178.google.com with SMTP id w10so2669467lbi.23 for ; Wed, 22 May 2013 16:29:08 -0700 (PDT) X-Received: by 10.112.120.170 with SMTP id ld10mr5143468lbb.31.1369265348302; Wed, 22 May 2013 16:29:08 -0700 (PDT) Received: from [192.169.1.99] (ppp85-141-101-230.pppoe.mtu-net.ru. [85.141.101.230]) by mx.google.com with ESMTPSA id c5sm3759960lbe.1.2013.05.22.16.29.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 May 2013 16:29:07 -0700 (PDT) Message-ID: <519D54BE.1030409@gmail.com> Date: Thu, 23 May 2013 03:29:02 +0400 From: Dmitry Osipenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Andrew Morton CC: a.zummo@towertech.it, akpm@linuxfoundation.org, ldewangan@nvidia.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH V2] rtc: tps6586x: device wakeup flags correction References: <1368368706-21261-1-git-send-email-digetx@gmail.com> <20130522152204.d46057964fa06cc0d56f8e6b@linux-foundation.org> In-Reply-To: <20130522152204.d46057964fa06cc0d56f8e6b@linux-foundation.org> X-Original-Sender: digetx@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of digetx@gmail.com designates 209.85.217.178 as permitted sender) smtp.mail=digetx@gmail.com; dkim=pass header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Use device_init_wakeup() instead of device_set_wakeup_capable() and move it before rtc dev registering. This fixes alarmtimer not registered when tps6586x rtc is the only wakeup compatible rtc in the system. Signed-off-by: Dmitry Osipenko --- V2: changed description drivers/rtc/rtc-tps6586x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c index 459c2ff..426901c 100644 --- a/drivers/rtc/rtc-tps6586x.c +++ b/drivers/rtc/rtc-tps6586x.c @@ -273,6 +273,8 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) return ret; } + device_init_wakeup(&pdev->dev, 1); + platform_set_drvdata(pdev, rtc); rtc->rtc = devm_rtc_device_register(&pdev->dev, dev_name(&pdev->dev), &tps6586x_rtc_ops, THIS_MODULE); @@ -292,7 +294,6 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) goto fail_rtc_register; } disable_irq(rtc->irq); - device_set_wakeup_capable(&pdev->dev, 1); return 0; fail_rtc_register: