Patchwork [Fortran,committed] PR57364 - add missing gfc_commit_symbol (4.8/4.9 regression)

login
register
mail settings
Submitter Tobias Burnus
Date May 22, 2013, 12:44 p.m.
Message ID <519CBDC1.4050905@net-b.de>
Download mbox | patch
Permalink /patch/245605/
State New
Headers show

Comments

Tobias Burnus - May 22, 2013, 12:44 p.m.
A rather obvious patch.

Committed to the trunk as Rev. 199196 after build+regtesting on 
x86-64-gnu-linux.
I will backport the patch to 4.9 in a while.

Tobias

Patch

2013-05-22  Tobias Burnus  <burnus@net-b.de>

	PR fortran/57364
	* resolve.c (get_temp_from_expr): Commit created sym.

2013-05-22  Tobias Burnus  <burnus@net-b.de>

	PR fortran/57364
	* gfortran.dg/defined_assignment_6.f90: New.

diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index 74e0aa4..6f32df8 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -9300,6 +9300,7 @@  get_temp_from_expr (gfc_expr *e, gfc_namespace *ns)
 
   gfc_set_sym_referenced (tmp->n.sym);
   gfc_add_flavor (&tmp->n.sym->attr, FL_VARIABLE, name, NULL);
+  gfc_commit_symbol (tmp->n.sym);
   e = gfc_lval_expr_from_sym (tmp->n.sym);
 
   /* Should the lhs be a section, use its array ref for the
diff --git a/gcc/testsuite/gfortran.dg/defined_assignment_6.f90 b/gcc/testsuite/gfortran.dg/defined_assignment_6.f90
new file mode 100644
index 0000000..a5666fe
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/defined_assignment_6.f90
@@ -0,0 +1,36 @@ 
+! { dg-do compile }
+!
+! PR fortran/57364
+!
+! Contributed by Damian Rouson
+!
+module ref_counter_implementation
+  type ref_counter
+  contains
+    procedure :: assign
+    generic :: assignment(=) => assign
+  end type
+contains
+  subroutine assign (lhs, rhs)
+    class (ref_counter), intent(inout) :: lhs
+    class (ref_counter), intent(in) :: rhs
+  end subroutine
+end module
+module foo_parent_implementation
+  use ref_counter_implementation ,only: ref_counter
+  type :: foo_parent
+    type(ref_counter) :: counter
+  end type
+contains
+  type(foo_parent) function new_foo_parent()
+  end function
+end module
+module foo_implementation
+  use foo_parent_implementation ,only: foo_parent,new_foo_parent
+  type, extends(foo_parent) :: foo
+  end type
+contains
+  type(foo) function new_foo()
+    new_foo%foo_parent = new_foo_parent()
+ end function
+end module