Patchwork clk/mpc85xx: Update the compatible string

login
register
mail settings
Submitter tang yuantian
Date May 22, 2013, 8:22 a.m.
Message ID <1369210939-25087-1-git-send-email-Yuantian.Tang@freescale.com>
Download mbox | patch
Permalink /patch/245574/
State Not Applicable
Headers show

Comments

tang yuantian - May 22, 2013, 8:22 a.m.
From: Tang Yuantian <yuantian.tang@freescale.com>

The compatible string of clock is changed from *-2 to *-2.0
on chassis 2. So updated it accordingly.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
 drivers/clk/clk-ppc-corenet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Mike Turquette - May 30, 2013, 6:57 p.m.
Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
> From: Tang Yuantian <yuantian.tang@freescale.com>
> 
> The compatible string of clock is changed from *-2 to *-2.0
> on chassis 2. So updated it accordingly.
> 
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>

Taken into clk-next.

Regards,
Mike

> ---
>  drivers/clk/clk-ppc-corenet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
> index a2d483f..e958707 100644
> --- a/drivers/clk/clk-ppc-corenet.c
> +++ b/drivers/clk/clk-ppc-corenet.c
> @@ -260,7 +260,7 @@ static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
>  
>  static const struct of_device_id ppc_clk_ids[] __initconst = {
>         { .compatible = "fsl,qoriq-clockgen-1.0", },
> -       { .compatible = "fsl,qoriq-clockgen-2", },
> +       { .compatible = "fsl,qoriq-clockgen-2.0", },
>         {}
>  };
>  
> -- 
> 1.8.0
Mike Turquette - May 30, 2013, 7:21 p.m.
Quoting Mike Turquette (2013-05-30 11:57:32)
> Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
> > From: Tang Yuantian <yuantian.tang@freescale.com>
> > 
> > The compatible string of clock is changed from *-2 to *-2.0
> > on chassis 2. So updated it accordingly.
> > 
> > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> 
> Taken into clk-next.
> 

One small nitpick.  I updated the $SUBJECT to:

clk: mpc85xx: Update the compatible string

The difference being "clk: mpc85xx:" versus "clk/mpc85xx:".  Please use
the former format in the future.

Thanks,
Mike

> Regards,
> Mike
> 
> > ---
> >  drivers/clk/clk-ppc-corenet.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
> > index a2d483f..e958707 100644
> > --- a/drivers/clk/clk-ppc-corenet.c
> > +++ b/drivers/clk/clk-ppc-corenet.c
> > @@ -260,7 +260,7 @@ static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
> >  
> >  static const struct of_device_id ppc_clk_ids[] __initconst = {
> >         { .compatible = "fsl,qoriq-clockgen-1.0", },
> > -       { .compatible = "fsl,qoriq-clockgen-2", },
> > +       { .compatible = "fsl,qoriq-clockgen-2.0", },
> >         {}
> >  };
> >  
> > -- 
> > 1.8.0
Kumar Gala - May 30, 2013, 7:26 p.m.
On May 30, 2013, at 2:21 PM, Mike Turquette wrote:

> Quoting Mike Turquette (2013-05-30 11:57:32)
>> Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
>>> From: Tang Yuantian <yuantian.tang@freescale.com>
>>> 
>>> The compatible string of clock is changed from *-2 to *-2.0
>>> on chassis 2. So updated it accordingly.
>>> 
>>> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
>> 
>> Taken into clk-next.
>> 
> 
> One small nitpick.  I updated the $SUBJECT to:
> 
> clk: mpc85xx: Update the compatible string
> 
> The difference being "clk: mpc85xx:" versus "clk/mpc85xx:".  Please use
> the former format in the future.
> 
> Thanks,
> Mike

Mike,

If clk-ppc-corenet.c went into v3.10, than I think this fix is needed there and shouldn't wait til v3.11

- k
Mike Turquette - May 30, 2013, 7:44 p.m.
Quoting Kumar Gala (2013-05-30 12:26:38)
> On May 30, 2013, at 2:21 PM, Mike Turquette wrote:
> 
> > Quoting Mike Turquette (2013-05-30 11:57:32)
> >> Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
> >>> From: Tang Yuantian <yuantian.tang@freescale.com>
> >>> 
> >>> The compatible string of clock is changed from *-2 to *-2.0
> >>> on chassis 2. So updated it accordingly.
> >>> 
> >>> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> >> 
> >> Taken into clk-next.
> >> 
> > 
> > One small nitpick.  I updated the $SUBJECT to:
> > 
> > clk: mpc85xx: Update the compatible string
> > 
> > The difference being "clk: mpc85xx:" versus "clk/mpc85xx:".  Please use
> > the former format in the future.
> > 
> > Thanks,
> > Mike
> 
> Mike,
> 
> If clk-ppc-corenet.c went into v3.10, than I think this fix is needed there and shouldn't wait til v3.11
> 

clk-ppc-corenet.c is first introduced in the current clk-next branch.
It is not merged into Linus' tree yet.

Regards,
Mike

> - k

Patch

diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
index a2d483f..e958707 100644
--- a/drivers/clk/clk-ppc-corenet.c
+++ b/drivers/clk/clk-ppc-corenet.c
@@ -260,7 +260,7 @@  static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
 
 static const struct of_device_id ppc_clk_ids[] __initconst = {
 	{ .compatible = "fsl,qoriq-clockgen-1.0", },
-	{ .compatible = "fsl,qoriq-clockgen-2", },
+	{ .compatible = "fsl,qoriq-clockgen-2.0", },
 	{}
 };