Patchwork data: klog.json: Remove _BBN from FWTS_TAG_ACPI_HOTPLUG since it is not related

login
register
mail settings
Submitter Alex Hung
Date May 22, 2013, 8:56 a.m.
Message ID <1369213018-22770-1-git-send-email-alex.hung@canonical.com>
Download mbox | patch
Permalink /patch/245571/
State Rejected
Headers show

Comments

Alex Hung - May 22, 2013, 8:56 a.m.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 data/klog.json | 8 --------
 1 file changed, 8 deletions(-)
Colin King - May 22, 2013, 12:21 p.m.
On 22/05/13 09:56, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  data/klog.json | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/data/klog.json b/data/klog.json
> index cb55071..606f41d 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -34,14 +34,6 @@
>     "label": "CommonAcpiHotplugOshpMethodFailed"
>    },
>    {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_HOTPLUG",
> -   "pattern": "shpchp.*acpi_shpchprm.*evaluate _BBN fail",
> -   "advice": "Hotplug _BBN method is missing",
> -   "label": "CommonAcpiHotPlugBbnMissing"
> -  },
> -  {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI",
> 
I don't understand why this pattern is being removed? Can you elaborate
a bit more? Thanks,

Colin

Patch

diff --git a/data/klog.json b/data/klog.json
index cb55071..606f41d 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -34,14 +34,6 @@ 
    "label": "CommonAcpiHotplugOshpMethodFailed"
   },
   {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_ACPI_HOTPLUG",
-   "pattern": "shpchp.*acpi_shpchprm.*evaluate _BBN fail",
-   "advice": "Hotplug _BBN method is missing",
-   "label": "CommonAcpiHotPlugBbnMissing"
-  },
-  {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI",