Patchwork [Raring,SRU,pull-request] patches to update be2net driver

login
register
mail settings
Submitter Jesse Sung
Date May 22, 2013, 7:46 a.m.
Message ID <CAH10aOhiBFBPoM=W7A+D9_25SYiyY7rx6GuD9sCzjKwrXzz=bg@mail.gmail.com>
Download mbox
Permalink /patch/245563/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/jesse/ubuntu-raring-lp1180217.git master

Comments

Jesse Sung - May 22, 2013, 7:46 a.m.
BugLink: https://launchpad.net/bugs/1180217

These are patches to update be2net driver in Ubuntu 13.04.

All of the changes are accepted by upstream already, but three of them
only include
be2net related part in upstream's changes:
376057a050d7ebb0ecc5c0be3846c0f2737dedc9
31cadef1e88d7203c36c1353449f67a0ea1aa16c
fe15de1c1385db94ad6803a63b56c63f61f0feff


The following changes since commit 26fe1fe3382caad4403d5c29268c11d6409237ae:

  UBUNTU: Ubuntu-3.8.0-22.33 (2013-05-15 14:08:51 -0500)

are available in the git repository at:

  git://kernel.ubuntu.com/jesse/ubuntu-raring-lp1180217.git master

for you to fetch changes up to 2e946546018867bcd1635363b581a5f06f0f3885:

  be2net: Fix to fail probe if MSI-X enable fails for a VF (2013-05-21
17:39:44 +0800)

----------------------------------------------------------------
Ajit Khaparde (4):
      be2net: Fix to use version 2 of cq_create for SkyHawk-R devices
      be2net: Fix to use 32-bit stats to report rx_drops_no_fragment
      be2net: Fix to show tx priority pause counter in ethtool -S
      be2net: Fix to receive Multicast Packets when Promiscuous mode
is enabled on certain devices

Craig Hada (1):
      be2net: enable IOMMU pass through for be2net

Gavin Shan (1):
      benet: Wait f/w POST until timeout

Ivan Vecera (2):
      be2net: remove unused variable 'sge'
      be2net: take care of __vlan_put_tag return value

Jiri Pirko (1):
      ethtool: fix drvinfo strings set in drivers

Joe Perches (2):
      be2net: Remove dma_alloc_coherent OOM messages
      be2net: dma_alloc_coherent: use __GFP_ZERO instead of memset(, 0)

Kalesh AP (2):
      be2net: Use GET_FUNCTION_CONFIG V1 cmd
      be2net: FLR must be first cmd issued to Lancer FW

Sarveshwar Bandi (1):
      be2net: Fix to show wol disabled/enabled state correctly.

Sathya Perla (4):
      be2net: fix re-loaded PF driver to re-gain control of its VFs
      be2net: update driver version to 4.6.x
      be2net: remove BUG_ON() in be_mcc_compl_is_new()
      be2net: use CSR-BAR SEMAPHORE reg for BE2/BE3

Somnath Kotur (5):
      be2net: enable interrupts in be_probe() (RoCE and other ULPs need them)
      be2net: Use new F/W mailbox cmd to manipulate interrupts.
      be2net: Fix firmware download for Lancer
      be2net: avoid napi_disable() when it has not been enabled
      be2net: Fix to fail probe if MSI-X enable fails for a VF

Suresh Reddy (4):
      be2net: Add support for setting and getting rx flow hash options
      be2net: Renamed rx_address_mismatch_errors to rx_address_filtered
      be2net: Avoid diagnostic test in certain versions of firmware to
avoid NIC freeze.
      be2net: Fixed memory leak

Vasundhara Volam (5):
      be2net: Update copyright year
      be2net: Use TXQ_CREATE_V2 cmd
      be2net: Don't log "Out of MCCQ wrbs" error
      be2net: Avoid flashing BE3 UFI on BE3-R chip.
      be2net: Use GET_PROFILE_CONFIG V1 cmd for BE3-R

 drivers/net/ethernet/emulex/benet/be.h         |  11 +-
 drivers/net/ethernet/emulex/benet/be_cmds.c    | 342 ++++++++++++++-------
 drivers/net/ethernet/emulex/benet/be_cmds.h    | 112 ++++---
 drivers/net/ethernet/emulex/benet/be_ethtool.c | 190 +++++++++++-
 drivers/net/ethernet/emulex/benet/be_hw.h      |  13 +-
 drivers/net/ethernet/emulex/benet/be_main.c    | 403 ++++++++++++++++---------
 drivers/net/ethernet/emulex/benet/be_roce.c    |   2 +-
 drivers/net/ethernet/emulex/benet/be_roce.h    |   2 +-
 8 files changed, 745 insertions(+), 330 deletions(-)
Andy Whitcroft - May 22, 2013, 10:53 a.m.
On Wed, May 22, 2013 at 03:46:17PM +0800, Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1180217
> 
> These are patches to update be2net driver in Ubuntu 13.04.

For those like myself who want to know what this update delivers find
this description in the bug:

	"Attaching set of patches to update be2net driver in Ubuntu
	 13.04. Apart from addressing bugs for already release hardware
	 (BladeEngine3), few patches are critical fixes to support the
	 upcoming hardware releases (SkyHawk-R and BE3-R)."

-apw
Stefan Bader - May 22, 2013, 11:01 a.m.
On 22.05.2013 12:53, Andy Whitcroft wrote:
> On Wed, May 22, 2013 at 03:46:17PM +0800, Jesse Sung wrote:
>> BugLink: https://launchpad.net/bugs/1180217
>>
>> These are patches to update be2net driver in Ubuntu 13.04.
> 
> For those like myself who want to know what this update delivers find
> this description in the bug:
> 
> 	"Attaching set of patches to update be2net driver in Ubuntu
> 	 13.04. Apart from addressing bugs for already release hardware
> 	 (BladeEngine3), few patches are critical fixes to support the
> 	 upcoming hardware releases (SkyHawk-R and BE3-R)."
> 
> -apw
> 
So this is (or should be) bringing the driver to a newer upstream kernel
version? It sounds a bit drastic (or too late) after release of non-lts kernels...
Sarveshwar Bandi - May 22, 2013, 11:09 a.m.
> So this is (or should be) bringing the driver to a newer upstream kernel version? It sounds a bit drastic (or too late) after release of non-lts kernels...

Stefan,
   Understand your concern. But majority of the patches are critical fixes (for upcoming hardware releases). The driver will not even load those for controllers without these. I really wanted to cherry pick them.
But the dependencies of these patches on the others was too much and didn't have a choice but to get others too. Did try to minimize the list.

Thanks,
Sarvesh
Tim Gardner - May 22, 2013, 2:06 p.m.
On 05/22/2013 01:46 AM, Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1180217
> 
> These are patches to update be2net driver in Ubuntu 13.04.
> 
> All of the changes are accepted by upstream already, but three of them
> only include
> be2net related part in upstream's changes:
> 376057a050d7ebb0ecc5c0be3846c0f2737dedc9
> 31cadef1e88d7203c36c1353449f67a0ea1aa16c
> fe15de1c1385db94ad6803a63b56c63f61f0feff
> 
> 
> The following changes since commit 26fe1fe3382caad4403d5c29268c11d6409237ae:
> 
>   UBUNTU: Ubuntu-3.8.0-22.33 (2013-05-15 14:08:51 -0500)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/jesse/ubuntu-raring-lp1180217.git master
> 
> for you to fetch changes up to 2e946546018867bcd1635363b581a5f06f0f3885:
> 
>   be2net: Fix to fail probe if MSI-X enable fails for a VF (2013-05-21
> 17:39:44 +0800)
> 

So, this patch set brings the be2net driver mostly up to v3.10-rc1
(ignoring some VLAN net changes). The partial backports you've mentioned
above are unnecessary. Otherwise, everything else appears to be clean
cherry picks and isolated to the benet driver.

What regression testing has been done using this patch set on the Raring
kernel ? When is the new hardware due to be released ? Is there a reason
that you can't wait for the 13.10 HWE kernel ?

rtg
Sarveshwar Bandi - May 23, 2013, 3:58 p.m.
Sorry about the slightly delayed response. Needed to get some clarification internally. 

-	Our hardware could get to customers sometime in next couple of months. Even adding for delays they might want to try it before 13.10 happens.
-	We have standard set of test cases that we execute before we submit the patches against any kernel. The test cases vary from sanity to some level of regression on all features from basic ping tests, vlan configurations, jumbo to sriov  (and more).

Thanks,
Sarvesh

-----Original Message-----
From: Tim Gardner [mailto:tim.gardner@canonical.com] 
Sent: Wednesday, May 22, 2013 7:36 PM
To: Jesse Sung
Cc: kernel-team@lists.ubuntu.com; Bandi,Sarveshwar; YK
Subject: Re: [Raring][SRU][pull-request] patches to update be2net driver

On 05/22/2013 01:46 AM, Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1180217
> 
> These are patches to update be2net driver in Ubuntu 13.04.
> 
> All of the changes are accepted by upstream already, but three of them 
> only include be2net related part in upstream's changes:
> 376057a050d7ebb0ecc5c0be3846c0f2737dedc9
> 31cadef1e88d7203c36c1353449f67a0ea1aa16c
> fe15de1c1385db94ad6803a63b56c63f61f0feff
> 
> 
> The following changes since commit 26fe1fe3382caad4403d5c29268c11d6409237ae:
> 
>   UBUNTU: Ubuntu-3.8.0-22.33 (2013-05-15 14:08:51 -0500)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/jesse/ubuntu-raring-lp1180217.git master
> 
> for you to fetch changes up to 2e946546018867bcd1635363b581a5f06f0f3885:
> 
>   be2net: Fix to fail probe if MSI-X enable fails for a VF (2013-05-21
> 17:39:44 +0800)
> 

So, this patch set brings the be2net driver mostly up to v3.10-rc1 (ignoring some VLAN net changes). The partial backports you've mentioned above are unnecessary. Otherwise, everything else appears to be clean cherry picks and isolated to the benet driver.

What regression testing has been done using this patch set on the Raring kernel ? When is the new hardware due to be released ? Is there a reason that you can't wait for the 13.10 HWE kernel ?

rtg
--
Tim Gardner tim.gardner@canonical.com