From patchwork Tue May 21 21:33:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 245412 X-Patchwork-Delegate: albert.aribaud@free.fr Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id BE2B62C00A9 for ; Wed, 22 May 2013 07:42:01 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 203154A0F2; Tue, 21 May 2013 23:42:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j-t0MV165klU; Tue, 21 May 2013 23:41:59 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id EC4B34A0F5; Tue, 21 May 2013 23:41:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 69B024A0F5 for ; Tue, 21 May 2013 23:41:52 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ma+X8mGGXpJz for ; Tue, 21 May 2013 23:41:47 +0200 (CEST) X-Greylist: delayed 445 seconds by postgrey-1.27 at theia; Tue, 21 May 2013 23:41:41 CEST X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) by theia.denx.de (Postfix) with ESMTPS id 549074A0F2 for ; Tue, 21 May 2013 23:41:41 +0200 (CEST) Received: by mail-ie0-f182.google.com with SMTP id a14so3301634iee.13 for ; Tue, 21 May 2013 14:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :in-reply-to:references; bh=MGKnm5K35H+LgT3e1Mr41Drc9STh1AJDuJKL/mIdoPc=; b=o8a685spAClgw3TkRB/wRPtq8WghFdxLO3ky1WxR4ao0BzwkH0987kVDCyQ3q35eGZ 1oT+dkK+2KDCJ3BPgjTmaWLFjMp2+udIQvZA9Yal6hTq9tIphBYrRX3x0u04r13iXjII uqo01zkyn1b2NsescwkAhhicQzVQxVwrdWplPAiOjv9vGl4dkA0aQ7OW75/hCKkIyAzD Ysa7ynI5bb2CHvZSOKL7xUevjhhSOZfzoRzblRgXtxrIuKKpWno/l4unwczp59m5fLNN HWYi5OQx4+ULDO66fglFY+++1YyfSslz2myBV6OT4lwqqo7wb6Bnr32sluTXXt/aO27U Hr0g== X-Received: by 10.50.92.69 with SMTP id ck5mr2405076igb.107.1369172052926; Tue, 21 May 2013 14:34:12 -0700 (PDT) Received: from rob-laptop.calxeda.com ([173.226.190.126]) by mx.google.com with ESMTPSA id d9sm18125696igr.4.2013.05.21.14.34.11 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 May 2013 14:34:12 -0700 (PDT) From: Rob Herring To: u-boot@lists.denx.de Date: Tue, 21 May 2013 16:33:47 -0500 Message-Id: <1369172027-3147-4-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1369172027-3147-1-git-send-email-robherring2@gmail.com> References: <1369172027-3147-1-git-send-email-robherring2@gmail.com> In-Reply-To: <1368647776-12940-1-git-send-email-robherring2@gmail.com> References: <1368647776-12940-1-git-send-email-robherring2@gmail.com> Cc: trini@ti.com, Rob Herring Subject: [U-Boot] [PATCH v2] ARM: move interrupt_init to before relocation X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Rob Herring interrupt_init also sets up the abort stack, but is not setup before relocation. So any aborts during relocation will hang and not print out any useful information. Fix this by moving the interrupt_init to after the stack setup in board_init_f. Signed-off-by: Rob Herring --- arch/arm/lib/board.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 09ab4ad..c90843e 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -447,6 +447,7 @@ void board_init_f(ulong bootflag) addr_sp += 128; /* leave 32 words for abort-stack */ gd->irq_sp = addr_sp; #endif + interrupt_init(); debug("New Stack Pointer is: %08lx\n", addr_sp); @@ -648,8 +649,6 @@ void board_init_r(gd_t *id, ulong dest_addr) misc_init_r(); #endif - /* set up exceptions */ - interrupt_init(); /* enable exceptions */ enable_interrupts();