Patchwork rtc: rtc-twl: Fix missing device_init_wakeup() when booted with device tree

login
register
mail settings
Submitter Tony Lindgren
Date May 21, 2013, 9:40 p.m.
Message ID <20130521214026.GV10378@atomide.com>
Download mbox | patch
Permalink /patch/245410/
State New
Headers show

Comments

Tony Lindgren - May 21, 2013, 9:40 p.m.
When booted in legacy mode device_init_wakeup() gets called
by drivers/mfd/twl-core.c when the children are initialized.
However, when booted using device tree, the children are
created with of_platform_populate() instead add_children().

This means that the RTC driver will not have device_init_wakeup()
set, and we need to call it from the driver probe like RTC drivers
typically do.

Without this we cannot test PM wake-up events on omaps for
cases where there may not be any physical wake-up event.

Reported-by: Kevin Hilman <khilman@linaro.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>

---

This fix is for the -rc cycle please.

Patch

--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -524,6 +524,7 @@  static int twl_rtc_probe(struct platform_device *pdev)
 	}
 
 	platform_set_drvdata(pdev, rtc);
+	device_init_wakeup(&pdev->dev, 1);
 	return 0;
 
 out2: