From patchwork Tue May 21 19:24:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 245394 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3C1682C00BC for ; Wed, 22 May 2013 05:24:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520Ab3EUTYY (ORCPT ); Tue, 21 May 2013 15:24:24 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:63562 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076Ab3EUTYY (ORCPT ); Tue, 21 May 2013 15:24:24 -0400 Received: by mail-la0-f41.google.com with SMTP id ee20so1132859lab.0 for ; Tue, 21 May 2013 12:24:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=to:subject:from:organization:cc:date:mime-version:content-type :content-transfer-encoding:message-id:x-gm-message-state; bh=1bai3bs1ytCFGJyAhPab8A0CRjFwn6dmyyHj3i9uydE=; b=Od27sg8YvqVNtzbbYYkrKGVP/gYiC+TIQyBjcu+CCI0Spy8+rXRnHOi30DFXsD5ZSo tYxnLLGYRecOIHm4E8edr9un5kVl1FcU/lbCuTN+LCsyYTbbPIHIrll8+KsdYb+quLLs JEYONkcGYfN1YKsHJJUYzWep4xOl1Xo7Fsv/WLRl/dVY+OJsTDPNjcDgUWJ76Wtop86f phcTMaXn7HW8ce4GUKeV05Fw/l8PgtH0wj8nQlj6AY8byVvsVw0ENnFDt4mrFtYYyaUi oWPKhV/bvHxlNeZgYQx6MIfib0Eo1P7KcvFT26oO4ui1dmX6paNunPCmjOVXrcJTfhie h8iQ== X-Received: by 10.112.133.202 with SMTP id pe10mr2336102lbb.54.1369164262346; Tue, 21 May 2013 12:24:22 -0700 (PDT) Received: from wasted.dev.rtsoft.ru (ppp91-76-151-135.pppoe.mtu-net.ru. [91.76.151.135]) by mx.google.com with ESMTPSA id e9sm702393lbj.3.2013.05.21.12.24.20 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 21 May 2013 12:24:21 -0700 (PDT) To: brking@us.ibm.com, JBottomley@parallels.com, linux-scsi@vger.kernel.org Subject: [PATCH] ipr: qc_fill_rtf() method should not store alternate status register From: Sergei Shtylyov Organization: Cogent Embedded Cc: linux-ide@vger.kernel.org, tj@kernel.org Date: Tue, 21 May 2013 23:24:22 +0400 MIME-Version: 1.0 Message-Id: <201305212324.22822.sergei.shtylyov@cogentembedded.com> X-Gm-Message-State: ALoCoQniB0rnajXqfo7Y0XfEKdMrdNRer2fxi+cIXCrfO2zNMutu2ymcf+ye2zjw3G05Pa0VEA9i Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org The 'ctl' field of the 'struct ata_taskfile' is not really dual purpose, i.e. it is not intended for storing the alternate status register (which is mapped at the same address in the legacy IDE controllers) in the qc_fill_rtf() method. No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status register's value in the 'ctl' field of 'qc->result_tf', hence this driver should not do this as well... Signed-off-by: Sergei Shtylyov Acked-by: Brian King --- The patch is against the recent Linus' tree. drivers/scsi/ipr.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux/drivers/scsi/ipr.c =================================================================== --- linux.orig/drivers/scsi/ipr.c +++ linux/drivers/scsi/ipr.c @@ -6662,7 +6662,6 @@ static bool ipr_qc_fill_rtf(struct ata_q tf->hob_lbal = g->hob_lbal; tf->hob_lbam = g->hob_lbam; tf->hob_lbah = g->hob_lbah; - tf->ctl = g->alt_status; return true; }