Patchwork [U-Boot,7/9] mx6qarm2: Return error if the SDHC port index is invalid

login
register
mail settings
Submitter Fabio Estevam
Date May 21, 2013, 5:32 p.m.
Message ID <1369157542-25734-7-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/245368/
State Changes Requested
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - May 21, 2013, 5:32 p.m.
When the SDHC port number index is invalid we should return an error code 
immediately.

Currently we return 'status', which has a value of zero, causing  
board_mmc_init() to incorrectly return sucess.

Fix this by returning -EINVAL instead.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx6qarm2/mx6qarm2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/board/freescale/mx6qarm2/mx6qarm2.c b/board/freescale/mx6qarm2/mx6qarm2.c
index e336746..e3e0b76 100644
--- a/board/freescale/mx6qarm2/mx6qarm2.c
+++ b/board/freescale/mx6qarm2/mx6qarm2.c
@@ -156,7 +156,7 @@  int board_mmc_init(bd_t *bis)
 			printf("Warning: you configured more USDHC controllers"
 				"(%d) then supported by the board (%d)\n",
 				index + 1, CONFIG_SYS_FSL_USDHC_NUM);
-			return status;
+			return -EINVAL;
 		}
 
 		status |= fsl_esdhc_initialize(bis, &usdhc_cfg[index]);