Patchwork [2/3] powerpc/fsl-pci: fix the unreachable warning message

login
register
mail settings
Submitter Kevin Hao
Date May 21, 2013, 12:04 p.m.
Message ID <1369137900-5748-3-git-send-email-haokexin@gmail.com>
Download mbox | patch
Permalink /patch/245295/
State Accepted
Commit 2d49c42a304750c5c38c9533d48bcc3fd7f8fe61
Delegated to: Scott Wood
Headers show

Comments

Kevin Hao - May 21, 2013, 12:04 p.m.
The (1ull << mem_log) is never greater than mem unless mem_log++;

Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
 arch/powerpc/sysdev/fsl_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index 028ac1f..3833c8f 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -305,10 +305,10 @@  static void setup_pci_atmu(struct pci_controller *hose)
 	if (early_find_capability(hose, 0, 0, PCI_CAP_ID_EXP)) {
 		/* Size window to exact size if power-of-two or one size up */
 		if ((1ull << mem_log) != mem) {
+			mem_log++;
 			if ((1ull << mem_log) > mem)
 				pr_info("%s: Setting PCI inbound window "
 					"greater than memory size\n", name);
-			mem_log++;
 		}
 
 		piwar |= ((mem_log - 1) & PIWAR_SZ_MASK);