From patchwork Tue May 21 10:57:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 245263 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 190FC2C00BF for ; Tue, 21 May 2013 20:58:12 +1000 (EST) Received: from localhost ([::1]:34699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UekGf-0003RM-QZ for incoming@patchwork.ozlabs.org; Tue, 21 May 2013 06:58:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UekGD-0003Na-2c for qemu-devel@nongnu.org; Tue, 21 May 2013 06:57:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UekGB-0004wh-Rs for qemu-devel@nongnu.org; Tue, 21 May 2013 06:57:40 -0400 Received: from mail-ee0-f54.google.com ([74.125.83.54]:60894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UekGB-0004wP-Lr for qemu-devel@nongnu.org; Tue, 21 May 2013 06:57:39 -0400 Received: by mail-ee0-f54.google.com with SMTP id e50so311405eek.13 for ; Tue, 21 May 2013 03:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=0Fd1dKD1MpXQsZTk7zBXV94nt8nycO8MjBhxSB1NNRg=; b=T1g1JS0lgAF/NvAgJRj4x+oZMSFGb24ycRL60s2O+smW+82KlSMOtVril4l3G52VwX OOHn0BN71nqc0mF2tCTQi6siZl6zMzoyKScEp6xWOPnJMj3/XCzG7VMYYJAQ6kZhTD3w 2r3uRnB1++9QteSq4GD4hDNPP9+ugqD+R/J2+l8Get1ZSk2jUKAh1iWXaFmvIzN1lkoo VEDzH13V7mBgja9MKBJUAwSOp+cldoGLvrIaQ8v01kWhFOTg1erhv1/wegz+lRWvv9uJ a4sq6AcqxfwDhzwiiVK59uuwDowR2A1lf0W4x5Wxr/ew5rwtwisKs1c1ljL2qx2x/pui IJ0Q== X-Received: by 10.15.111.75 with SMTP id ci51mr5384474eeb.7.1369133858760; Tue, 21 May 2013 03:57:38 -0700 (PDT) Received: from playground.lan (net-37-116-223-193.cust.dsl.vodafone.it. [37.116.223.193]) by mx.google.com with ESMTPSA id a5sm2754398ees.6.2013.05.21.03.57.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 21 May 2013 03:57:37 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 21 May 2013 12:57:02 +0200 Message-Id: <1369133851-1894-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.83.54 Cc: peter.maydell@linaro.org, jan.kiszka@gmail.com, David Gibson Subject: [Qemu-devel] [PATCH 01/30] exec: remove obsolete comment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org See how we call memory_region_section_addr two lines below to convert a physical address to a base address in the region. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell --- exec.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/exec.c b/exec.c index aec65c5..197625c 100644 --- a/exec.c +++ b/exec.c @@ -639,12 +639,6 @@ hwaddr memory_region_section_get_iotlb(CPUArchState *env, iotlb |= phys_section_rom; } } else { - /* IO handlers are currently passed a physical address. - It would be nice to pass an offset from the base address - of that region. This would avoid having to special case RAM, - and avoid full address decoding in every device. - We can't use the high bits of pd for this because - IO_MEM_ROMD uses these as a ram address. */ iotlb = section - phys_sections; iotlb += memory_region_section_addr(section, paddr); }