Message ID | 1369133851-1894-2-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
On 21 May 2013 11:57, Paolo Bonzini <pbonzini@redhat.com> wrote: > See how we call memory_region_section_addr two lines below to > convert a physical address to a base address in the region. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> (I'm sure I've reviewed this patch already in a previous version) -- PMM
diff --git a/exec.c b/exec.c index aec65c5..197625c 100644 --- a/exec.c +++ b/exec.c @@ -639,12 +639,6 @@ hwaddr memory_region_section_get_iotlb(CPUArchState *env, iotlb |= phys_section_rom; } } else { - /* IO handlers are currently passed a physical address. - It would be nice to pass an offset from the base address - of that region. This would avoid having to special case RAM, - and avoid full address decoding in every device. - We can't use the high bits of pd for this because - IO_MEM_ROMD uses these as a ram address. */ iotlb = section - phys_sections; iotlb += memory_region_section_addr(section, paddr); }
See how we call memory_region_section_addr two lines below to convert a physical address to a base address in the region. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- exec.c | 6 ------ 1 file changed, 6 deletions(-)