From patchwork Mon May 20 16:21:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 245064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 911062C00B9 for ; Tue, 21 May 2013 02:33:02 +1000 (EST) Received: from localhost ([::1]:48043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeT1A-0001u1-Kj for incoming@patchwork.ozlabs.org; Mon, 20 May 2013 12:33:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeT0q-0001th-2E for qemu-devel@nongnu.org; Mon, 20 May 2013 12:32:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeT0i-0006cI-H3 for qemu-devel@nongnu.org; Mon, 20 May 2013 12:32:40 -0400 Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:1d0::1]:56976 helo=mnementh.archaic.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeSq2-00031h-K7; Mon, 20 May 2013 12:21:30 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1UeSpx-00007O-3G; Mon, 20 May 2013 17:21:25 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 20 May 2013 17:21:24 +0100 Message-Id: <1369066884-431-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: qemu-trivial@nongnu.org, Anthony Liguori , John Rigby , =?UTF-8?q?Andreas=20F=C3=A4rber?= , patches@linaro.org Subject: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Reformat the qapi-schema TargetType enumeration so that it has just one target architecture name per line. This allows patches for adding new targets to just add a single line, rather than having to reformat most of the list (resulting in a hard-to-check diff). Signed-off-by: Peter Maydell Reviewed-by: Eric Blake Reviewed-by: Andreas Färber --- d15a9c23 is an example of what you get otherwise. I would much prefer it if we autogenerated this list so you didn't need to change this file at all to add a new target, but Anthony is against that; so this is at least an improvement. qapi-schema.json | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 199744a..a8d361e 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3018,10 +3018,32 @@ # Since: 1.2.0 ## { 'enum': 'TargetType', - 'data': [ 'alpha', 'arm', 'cris', 'i386', 'lm32', 'm68k', 'microblazeel', - 'microblaze', 'mips64el', 'mips64', 'mipsel', 'mips', 'moxie', - 'or32', 'ppc64', 'ppcemb', 'ppc', 's390x', 'sh4eb', 'sh4', - 'sparc64', 'sparc', 'unicore32', 'x86_64', 'xtensaeb', 'xtensa' ] } + 'data': [ 'alpha', + 'arm', + 'cris', + 'i386', + 'lm32', + 'm68k', + 'microblazeel', + 'microblaze', + 'mips64el', + 'mips64', + 'mipsel', + 'mips', + 'moxie', + 'or32', + 'ppc64', + 'ppcemb', + 'ppc', + 's390x', + 'sh4eb', + 'sh4', + 'sparc64', + 'sparc', + 'unicore32', + 'x86_64', + 'xtensaeb', + 'xtensa' ] } ## # @TargetInfo: