Patchwork [05/12] lua-ev: New package

login
register
mail settings
Submitter Assaf Inbal
Date May 20, 2013, 12:56 p.m.
Message ID <1369054604-26139-5-git-send-email-shmuelzon@gmail.com>
Download mbox | patch
Permalink /patch/245025/
State Changes Requested
Headers show

Comments

Assaf Inbal - May 20, 2013, 12:56 p.m.
Lua bindings for libev

Signed-off-by: Assaf Inbal <shmuelzon@gmail.com>
---
 package/Config.in        |  1 +
 package/lua-ev/Config.in |  7 +++++++
 package/lua-ev/lua-ev.mk | 16 ++++++++++++++++
 3 files changed, 24 insertions(+)
 create mode 100644 package/lua-ev/Config.in
 create mode 100644 package/lua-ev/lua-ev.mk
Francois Perrad - May 20, 2013, 4:05 p.m.
2013/5/20 Assaf Inbal <shmuelzon@gmail.com>

> Lua bindings for libev
>
> Signed-off-by: Assaf Inbal <shmuelzon@gmail.com>
> ---
>  package/Config.in        |  1 +
>  package/lua-ev/Config.in |  7 +++++++
>  package/lua-ev/lua-ev.mk | 16 ++++++++++++++++
>  3 files changed, 24 insertions(+)
>  create mode 100644 package/lua-ev/Config.in
>  create mode 100644 package/lua-ev/lua-ev.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 0845881..e94cb39 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -312,6 +312,7 @@ source "package/luacjson/Config.in"
>  source "package/luaexpat/Config.in"
>  source "package/luafilesystem/Config.in"
>  source "package/luasocket/Config.in"
> +source "package/lua-ev/Config.in"
>  source "package/lua-msgpack-native/Config.in"
>  source "package/rings/Config.in"
>  source "package/wsapi/Config.in"
> diff --git a/package/lua-ev/Config.in b/package/lua-ev/Config.in
> new file mode 100644
> index 0000000..1e89c27
> --- /dev/null
> +++ b/package/lua-ev/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LUA_EV
> +       bool "lua-ev"
> +       select BR2_PACKAGE_LIBEV
> +       help
> +         Get access to the libev library from Lua.
> +
> +         https://github.com/brimworks/lua-ev
> diff --git a/package/lua-ev/lua-ev.mk b/package/lua-ev/lua-ev.mk
> new file mode 100644
> index 0000000..208a1ba
> --- /dev/null
> +++ b/package/lua-ev/lua-ev.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# lua-ev
> +#
> +#############################################################
> +
> +LUA_EV_VERSION = master
> +LUA_EV_SITE = git://github.com/brimworks/lua-ev.git
> +LUA_EV_SITE_METHOD = git
>

master is not a fixed reference.

-LUA_EV_VERSION = master
-LUA_EV_SITE = git://github.com/brimworks/lua-ev.git
-LUA_EV_SITE_METHOD = git
+LUA_EV_VERSION = g458165b
+LUA_EV_SITE = http://github.com/brimworks/lua-ev/tarball/master



> +LUA_EV_DEPENDENCIES = lua libev
> +LUA_EV_LICENSE = MIT
> +LUA_EV_LICENSE_FILES = README
> +LUA_EV_CONF_OPT = -DINSTALL_CMOD="/usr/lib/lua"
> +
> +$(eval $(cmake-package))
> +
>

Congratulations, this is the first Lua module using the CMake
infrastructure.

François



> --
> 1.8.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
Peter Korsgaard - June 16, 2013, 7:53 p.m.
>>>>> "François" == François Perrad <francois.perrad@gadz.org> writes:

 François> 2013/5/20 Assaf Inbal <shmuelzon@gmail.com>

 François>     Lua bindings for libev

 François>     +++ b/package/lua-ev/lua-ev.mk
 François>     @@ -0,0 +1,16 @@
 François>     +#############################################################
 François>     +#
 François>     +# lua-ev
 François>     +#
 François>     +#############################################################
 François>     +
 François>     +LUA_EV_VERSION = master
 François>     +LUA_EV_SITE = git://github.com/brimworks/lua-ev.git
 François>     +LUA_EV_SITE_METHOD = git


 François> master is not a fixed reference.

 François> -LUA_EV_VERSION = master
 François> -LUA_EV_SITE = git://github.com/brimworks/lua-ev.git
 François> -LUA_EV_SITE_METHOD = git
 François> +LUA_EV_VERSION = g458165b
 François> +LUA_EV_SITE = http://github.com/brimworks/lua-ev/tarball/master

Assaf, will you send an updated patch taking the review feedback into
consideration?
Assaf Inbal - June 17, 2013, 5:58 a.m.
>
> Assaf, will you send an updated patch taking the review feedback into
> consideration?


Yes, although I've made a change to the above feedback.
As far as I can tell, it will always pull master, and just change the
download file name, so it still isn't a fixed reference.

The attached patch should take care of that.
Peter Korsgaard - June 17, 2013, 9:14 p.m.
>>>>> "Assaf" == Assaf Inbal <shmuelzon@gmail.com> writes:

 Assaf>     Assaf, will you send an updated patch taking the review feedback into
 Assaf>     consideration?


 Assaf> Yes, although I've made a change to the above feedback.
 Assaf> As far as I can tell, it will always pull master, and just change the download
 Assaf> file name, so it still isn't a fixed reference.

Committed with minor tweaks, thanks.

Patch

diff --git a/package/Config.in b/package/Config.in
index 0845881..e94cb39 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -312,6 +312,7 @@  source "package/luacjson/Config.in"
 source "package/luaexpat/Config.in"
 source "package/luafilesystem/Config.in"
 source "package/luasocket/Config.in"
+source "package/lua-ev/Config.in"
 source "package/lua-msgpack-native/Config.in"
 source "package/rings/Config.in"
 source "package/wsapi/Config.in"
diff --git a/package/lua-ev/Config.in b/package/lua-ev/Config.in
new file mode 100644
index 0000000..1e89c27
--- /dev/null
+++ b/package/lua-ev/Config.in
@@ -0,0 +1,7 @@ 
+config BR2_PACKAGE_LUA_EV
+	bool "lua-ev"
+	select BR2_PACKAGE_LIBEV
+	help
+	  Get access to the libev library from Lua.
+
+	  https://github.com/brimworks/lua-ev
diff --git a/package/lua-ev/lua-ev.mk b/package/lua-ev/lua-ev.mk
new file mode 100644
index 0000000..208a1ba
--- /dev/null
+++ b/package/lua-ev/lua-ev.mk
@@ -0,0 +1,16 @@ 
+#############################################################
+#
+# lua-ev
+#
+#############################################################
+
+LUA_EV_VERSION = master
+LUA_EV_SITE = git://github.com/brimworks/lua-ev.git
+LUA_EV_SITE_METHOD = git
+LUA_EV_DEPENDENCIES = lua libev
+LUA_EV_LICENSE = MIT
+LUA_EV_LICENSE_FILES = README
+LUA_EV_CONF_OPT = -DINSTALL_CMOD="/usr/lib/lua"
+
+$(eval $(cmake-package))
+