Patchwork [03/12] sqlite: Added host compilation support

login
register
mail settings
Submitter Assaf Inbal
Date May 20, 2013, 12:56 p.m.
Message ID <1369054604-26139-3-git-send-email-shmuelzon@gmail.com>
Download mbox | patch
Permalink /patch/245022/
State Rejected
Headers show

Comments

Assaf Inbal - May 20, 2013, 12:56 p.m.
Signed-off-by: Assaf Inbal <shmuelzon@gmail.com>
---
 package/sqlite/sqlite.mk | 2 ++
 1 file changed, 2 insertions(+)
Yann E. MORIN - May 20, 2013, 1:26 p.m.
Assaf, All,

On 2013-05-20 15:56 +0300, Assaf Inbal spake thusly:
> 
> Signed-off-by: Assaf Inbal <shmuelzon@gmail.com>
> ---
>  package/sqlite/sqlite.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
> index 8eb6b2f..39d5528 100644
> --- a/package/sqlite/sqlite.mk
> +++ b/package/sqlite/sqlite.mk
> @@ -54,6 +54,7 @@ SQLITE_CONF_OPT += --with-readline-inc="-I$(STAGING_DIR)/usr/include"
>  else
>  SQLITE_CONF_OPT += --disable-readline
>  endif
> +HOST_SQLITE_CONF_OPT += --disable-readline
>  
>  define SQLITE_UNINSTALL_TARGET_CMDS
>  	rm -f $(TARGET_DIR)/usr/bin/sqlite3
> @@ -68,3 +69,4 @@ define SQLITE_UNINSTALL_STAGING_CMDS
>  endef
>  
>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))

What do you need host-sqlite for? None of the packages you're adding in
your series depends on host-sqlite (AFAICS).

Regards,
Yann E. MORIN.
Assaf Inbal - May 20, 2013, 2:27 p.m.
Hey,

You're correct, However, I have a personal package which relies on
sqlite as a part of the build process.
I figured that since I already spent the time to write those entire
two lines and made sure it works, I might as well send in the patch.

On 20 במאי 2013, at 16:26, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Assaf, All,
>
> On 2013-05-20 15:56 +0300, Assaf Inbal spake thusly:
>>
>> Signed-off-by: Assaf Inbal <shmuelzon@gmail.com>
>> ---
>> package/sqlite/sqlite.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
>> index 8eb6b2f..39d5528 100644
>> --- a/package/sqlite/sqlite.mk
>> +++ b/package/sqlite/sqlite.mk
>> @@ -54,6 +54,7 @@ SQLITE_CONF_OPT += --with-readline-inc="-I$(STAGING_DIR)/usr/include"
>> else
>> SQLITE_CONF_OPT += --disable-readline
>> endif
>> +HOST_SQLITE_CONF_OPT += --disable-readline
>>
>> define SQLITE_UNINSTALL_TARGET_CMDS
>>    rm -f $(TARGET_DIR)/usr/bin/sqlite3
>> @@ -68,3 +69,4 @@ define SQLITE_UNINSTALL_STAGING_CMDS
>> endef
>>
>> $(eval $(autotools-package))
>> +$(eval $(host-autotools-package))
>
> What do you need host-sqlite for? None of the packages you're adding in
> your series depends on host-sqlite (AFAICS).
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
Yann E. MORIN - May 20, 2013, 4 p.m.
Assaf, All,

Please, do not to-post. Reply in-place, as below:

On 2013-05-20 17:27 +0300, Assaf Inbal spake thusly:
> You're correct, However, I have a personal package which relies on
> sqlite as a part of the build process.

OK, I understand.

> I figured that since I already spent the time to write those entire
> two lines and made sure it works, I might as well send in the patch.

It's not my take to decide, but I guess as no package in upstream
Buildroot depends on host-sqlite, there is no reason we add it.

Unless you can submit your package for inclusion, that is, in which
case you should submit this host-sqlite package at the same time
(but in a separate patch, of course).

Regards,
Yann E. MORIN.

Patch

diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
index 8eb6b2f..39d5528 100644
--- a/package/sqlite/sqlite.mk
+++ b/package/sqlite/sqlite.mk
@@ -54,6 +54,7 @@  SQLITE_CONF_OPT += --with-readline-inc="-I$(STAGING_DIR)/usr/include"
 else
 SQLITE_CONF_OPT += --disable-readline
 endif
+HOST_SQLITE_CONF_OPT += --disable-readline
 
 define SQLITE_UNINSTALL_TARGET_CMDS
 	rm -f $(TARGET_DIR)/usr/bin/sqlite3
@@ -68,3 +69,4 @@  define SQLITE_UNINSTALL_STAGING_CMDS
 endef
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))