Patchwork More vector folding

login
register
mail settings
Submitter Marc Glisse
Date May 17, 2013, 2:37 p.m.
Message ID <alpine.DEB.2.02.1305171635190.7184@stedding.saclay.inria.fr>
Download mbox | patch
Permalink /patch/244665/
State New
Headers show

Comments

Marc Glisse - May 17, 2013, 2:37 p.m.
On Fri, 17 May 2013, Jakub Jelinek wrote:

> On Fri, May 17, 2013 at 04:23:08PM +0200, Marc Glisse wrote:
>> 2013-05-17  Marc Glisse  <marc.glisse@inria.fr>
>>
>> 	PR regression/57313
>> 	* gcc.dg/binop-xor3.c: Restrict to platforms known to work (x86).
>
> I'd say it should be PR testsuite/57313 (and the PR changed to that).

Ok, thanks.

I was actually thinking that it might be better to put the target selector 
on dg-final, as in the attached. Which do you prefer?
Jakub Jelinek - May 17, 2013, 2:45 p.m.
On Fri, May 17, 2013 at 04:37:45PM +0200, Marc Glisse wrote:
> On Fri, 17 May 2013, Jakub Jelinek wrote:
> 
> >On Fri, May 17, 2013 at 04:23:08PM +0200, Marc Glisse wrote:
> >>2013-05-17  Marc Glisse  <marc.glisse@inria.fr>
> >>
> >>	PR regression/57313
> >>	* gcc.dg/binop-xor3.c: Restrict to platforms known to work (x86).
> >
> >I'd say it should be PR testsuite/57313 (and the PR changed to that).
> 
> Ok, thanks.
> 
> I was actually thinking that it might be better to put the target
> selector on dg-final, as in the attached. Which do you prefer?

Doesn't really matter, both are fine.

	Jakub

Patch

Index: gcc.dg/binop-xor3.c

===================================================================
--- gcc.dg/binop-xor3.c	(revision 199006)

+++ gcc.dg/binop-xor3.c	(working copy)

@@ -1,11 +1,11 @@ 

 /* { dg-do compile } */
 /* { dg-options "-O2 -fdump-tree-optimized" } */
 
 int
 foo (int a, int b)
 {
   return ((a && !b) || (!a && b));
 }
 
-/* { dg-final { scan-tree-dump-times "\\\^" 1 "optimized" } } */

+/* { dg-final { scan-tree-dump-times "\\\^" 1 "optimized" { target i?86-*-* x86_64-*-* } } } */

 /* { dg-final { cleanup-tree-dump "optimized" } } */