Patchwork FeatureRequest: add project name to patch update notification

login
register
mail settings
Submitter Wolfram Sang
Date May 17, 2013, 10:23 a.m.
Message ID <20130517102301.GJ17056@katana>
Download mbox | patch
Permalink /patch/244610/
State Accepted
Headers show

Comments

Wolfram Sang - May 17, 2013, 10:23 a.m.
Hi,

I noticed that the project name is not included in the
patch-update-notification-mail. I guess this could be useful in case one
patch has been sent to multiple lists. Pseudo patch follows.

Thanks,

   Wolfram
Mauro Carvalho Chehab - May 17, 2013, 12:49 p.m.
Em Fri, 17 May 2013 12:23:05 +0200
Wolfram Sang <wsa@the-dreams.de> escreveu:

> Hi,
> 
> I noticed that the project name is not included in the
> patch-update-notification-mail. I guess this could be useful in case one
> patch has been sent to multiple lists. Pseudo patch follows.

Actually, I would rather prefer to (also) allow having separate notification
pages per project. In my case, I changed the notification template to
better explain what each status means, in terms of reviewing process, for
the Kernel patches (the vast majority of stuff we handle at LinuxTV). However,
the explanations there are meaningless for the other project supported there
(VDR, maintained by someone else).

I would love to keep the original notification msg to the VDR project, while
having this special notification message for the Kernel media patches.

Regards,
Mauro

> 
> Thanks,
> 
>    Wolfram
> 
> diff --git a/templates/patchwork/patch-change-notification-subject.text b/templates/patchwork/patch-change-notification-subject.text
> index 02ee55b..6f9e5d6 100644
> --- a/templates/patchwork/patch-change-notification-subject.text
> +++ b/templates/patchwork/patch-change-notification-subject.text
> @@ -1 +1 @@
> -Patch update notification: {{notifications|length}} patch{{notifications|length|pluralize:"es"}} updated
> +Patch update notification for {{project|shortname}}: {{notifications|length}} patch{{notifications|length|pluralize:"es"}} updated
> diff --git a/templates/patchwork/patch-change-notification.mail b/templates/patchwork/patch-change-notification.mail
> index 19a2a09..d11bc24 100644
> --- a/templates/patchwork/patch-change-notification.mail
> +++ b/templates/patchwork/patch-change-notification.mail
> @@ -1,6 +1,6 @@
>  Hello,
>  
> -The following patch{{notifications|length|pluralize:"es"}} (submitted by you) {{notifications|length|pluralize:"has,have"}} been updated in patchwork:
> +The following patch{{notifications|length|pluralize:"es"}} (submitted by you) {{notifications|length|pluralize:"has,have"}} been updated in the patchwork repository for {{project|shortname}} ({{project|longname}}):
>  {% for notification in notifications %}
>   * {{notification.patch.name|safe}}
>       - http://{{site.domain}}{{notification.patch.get_absolute_url}}
> _______________________________________________
> Patchwork mailing list
> Patchwork@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork




Cheers,
Mauro

Patch

diff --git a/templates/patchwork/patch-change-notification-subject.text b/templates/patchwork/patch-change-notification-subject.text
index 02ee55b..6f9e5d6 100644
--- a/templates/patchwork/patch-change-notification-subject.text
+++ b/templates/patchwork/patch-change-notification-subject.text
@@ -1 +1 @@ 
-Patch update notification: {{notifications|length}} patch{{notifications|length|pluralize:"es"}} updated
+Patch update notification for {{project|shortname}}: {{notifications|length}} patch{{notifications|length|pluralize:"es"}} updated
diff --git a/templates/patchwork/patch-change-notification.mail b/templates/patchwork/patch-change-notification.mail
index 19a2a09..d11bc24 100644
--- a/templates/patchwork/patch-change-notification.mail
+++ b/templates/patchwork/patch-change-notification.mail
@@ -1,6 +1,6 @@ 
 Hello,
 
-The following patch{{notifications|length|pluralize:"es"}} (submitted by you) {{notifications|length|pluralize:"has,have"}} been updated in patchwork:
+The following patch{{notifications|length|pluralize:"es"}} (submitted by you) {{notifications|length|pluralize:"has,have"}} been updated in the patchwork repository for {{project|shortname}} ({{project|longname}}):
 {% for notification in notifications %}
  * {{notification.patch.name|safe}}
      - http://{{site.domain}}{{notification.patch.get_absolute_url}}