Patchwork [v2] clk: si5351: declare all device IDs for module loading

login
register
mail settings
Submitter Jean-Francois Moine
Date May 16, 2013, 3:49 p.m.
Message ID <20130516174916.2daa49b6@armhf>
Download mbox | patch
Permalink /patch/244356/
State New
Headers show

Comments

Jean-Francois Moine - May 16, 2013, 3:49 p.m.
When the si5351 driver is a kernel module, it is loaded into memory
from its i2c device IDs, but not from its DT compatible properties.

This patch declares the i2c device IDs of all chip variants.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
v2: subject change - was "ARM: dove: ..."
--- 
 drivers/clk/clk-si5351.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Mike Turquette - May 16, 2013, 8:13 p.m.
Quoting Jean-Francois Moine (2013-05-16 08:49:16)
> When the si5351 driver is a kernel module, it is loaded into memory
> from its i2c device IDs, but not from its DT compatible properties.
> 
> This patch declares the i2c device IDs of all chip variants.
> 
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>

Taken into clk-next.

Thanks,
Mike

> ---
> v2: subject change - was "ARM: dove: ..."
> --- 
>  drivers/clk/clk-si5351.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> index 8927284..9ebdddd 100644
> --- a/drivers/clk/clk-si5351.c
> +++ b/drivers/clk/clk-si5351.c
> @@ -1490,7 +1490,10 @@ static int si5351_i2c_probe(struct i2c_client *client,
>  }
>  
>  static const struct i2c_device_id si5351_i2c_ids[] = {
> -       { "silabs,si5351", 0 },
> +       { "si5351a", 0 },
> +       { "si5351a-msop", 0 },
> +       { "si5351b", 0 },
> +       { "si5351c", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, si5351_i2c_ids);
> 
> 
> -- 
> Ken ar c'hentaƱ |             ** Breizh ha Linux atav! **
> Jef             |               http://moinejf.free.fr/
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Patch

diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index 8927284..9ebdddd 100644
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -1490,7 +1490,10 @@  static int si5351_i2c_probe(struct i2c_client *client,
 }
 
 static const struct i2c_device_id si5351_i2c_ids[] = {
-	{ "silabs,si5351", 0 },
+	{ "si5351a", 0 },
+	{ "si5351a-msop", 0 },
+	{ "si5351b", 0 },
+	{ "si5351c", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, si5351_i2c_ids);