Patchwork [12/33] drivers/mtd/nand: don't check resource with devm_ioremap_resource

login
register
mail settings
Submitter Wolfram Sang
Date May 16, 2013, 11:15 a.m.
Message ID <1368702961-4325-13-git-send-email-wsa@the-dreams.de>
Download mbox | patch
Permalink /patch/244292/
State Accepted
Commit e222a6eb77ca9897076761c854c25ffc43ab8949
Headers show

Comments

Wolfram Sang - May 16, 2013, 11:15 a.m.
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 drivers/mtd/nand/lpc32xx_mlc.c |    5 -----
 1 file changed, 5 deletions(-)

Patch

diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
index a94facb..fd1df5e 100644
--- a/drivers/mtd/nand/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/lpc32xx_mlc.c
@@ -672,11 +672,6 @@  static int lpc32xx_nand_probe(struct platform_device *pdev)
 	}
 
 	rc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (rc == NULL) {
-		dev_err(&pdev->dev, "No memory resource found for device!\r\n");
-		return -ENXIO;
-	}
-
 	host->io_base = devm_ioremap_resource(&pdev->dev, rc);
 	if (IS_ERR(host->io_base))
 		return PTR_ERR(host->io_base);