Patchwork ARM: dove: declare all device IDs for module loading

login
register
mail settings
Submitter Jean-Francois Moine
Date May 16, 2013, 11:12 a.m.
Message ID <20130516131233.30145f82@armhf>
Download mbox | patch
Permalink /patch/244266/
State New
Headers show

Comments

Jean-Francois Moine - May 16, 2013, 11:12 a.m.
When the si5351 driver is a kernel module, it is loaded into memory
from its i2c device IDs, but not from its DT compatible properties.

This patch declares the i2c device IDs of all chip variants.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
--- 
 drivers/clk/clk-si5351.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Jason - May 16, 2013, 3:28 p.m.
Jean-Francois,

Thanks for the patch, but you may want to change the subject "clk:
si5351: ..."  Other than that,

On Thu, May 16, 2013 at 01:12:33PM +0200, Jean-Francois Moine wrote:
> When the si5351 driver is a kernel module, it is loaded into memory
> from its i2c device IDs, but not from its DT compatible properties.
> 
> This patch declares the i2c device IDs of all chip variants.
> 
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> --- 
>  drivers/clk/clk-si5351.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

Patch

diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index 8927284..9ebdddd 100644
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -1490,7 +1490,10 @@  static int si5351_i2c_probe(struct i2c_client *client,
 }
 
 static const struct i2c_device_id si5351_i2c_ids[] = {
-	{ "silabs,si5351", 0 },
+	{ "si5351a", 0 },
+	{ "si5351a-msop", 0 },
+	{ "si5351b", 0 },
+	{ "si5351c", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, si5351_i2c_ids);