Patchwork [U-Boot,06/10] ARM: highbank: avoid bss write in timer_init

login
register
mail settings
Submitter Rob Herring
Date May 15, 2013, 7:56 p.m.
Message ID <1368647776-12940-6-git-send-email-robherring2@gmail.com>
Download mbox | patch
Permalink /patch/244172/
State Superseded
Delegated to: Albert ARIBAUD
Headers show

Comments

Rob Herring - May 15, 2013, 7:56 p.m.
From: Rob Herring <rob.herring@calxeda.com>

The timer_init function is called before relocation and writes to bss data
were corrupting relocation data. Fix this by removing the call to
reset_timer_masked. The initial timer count should be 0 or near 0 anyway,
so initializing the variables are not needed.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
 arch/arm/cpu/armv7/highbank/timer.c | 2 --
 1 file changed, 2 deletions(-)

Patch

diff --git a/arch/arm/cpu/armv7/highbank/timer.c b/arch/arm/cpu/armv7/highbank/timer.c
index d93de1e..832c012 100644
--- a/arch/arm/cpu/armv7/highbank/timer.c
+++ b/arch/arm/cpu/armv7/highbank/timer.c
@@ -46,8 +46,6 @@  int timer_init(void)
 	writel(SYSTIMER_EN | SYSTIMER_32BIT | SYSTIMER_PRESC_256,
 		&systimer_base->timer0control);
 
-	reset_timer_masked();
-
 	return 0;
 
 }