Patchwork [U-Boot,09/10] ARM: highbank: fix build with CONFIG_MISC_INIT_R turned off

login
register
mail settings
Submitter Rob Herring
Date May 15, 2013, 7:56 p.m.
Message ID <1368647776-12940-9-git-send-email-robherring2@gmail.com>
Download mbox | patch
Permalink /patch/244171/
State Superseded
Delegated to: Albert ARIBAUD
Headers show

Comments

Rob Herring - May 15, 2013, 7:56 p.m.
From: Rob Herring <rob.herring@calxeda.com>

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
 board/highbank/highbank.c | 2 ++
 1 file changed, 2 insertions(+)
Albert ARIBAUD - May 15, 2013, 8:31 p.m.
Hi Rob,

On Wed, 15 May 2013 14:56:15 -0500, Rob Herring <robherring2@gmail.com>
wrote:

> From: Rob Herring <rob.herring@calxeda.com>
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>

This commit could have more meaningful summary, such as
"compile misc_init_r only if CONFIG_MISC_INIT_R"

> ---
>  board/highbank/highbank.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/highbank/highbank.c b/board/highbank/highbank.c
> index 4cc4b1c..82ebeea 100644
> --- a/board/highbank/highbank.c
> +++ b/board/highbank/highbank.c
> @@ -60,6 +60,7 @@ int board_eth_init(bd_t *bis)
>  	return rc;
>  }
>  
> +#ifdef CONFIG_MISC_INIT_R
>  int misc_init_r(void)
>  {
>  	char envbuffer[16];
> @@ -81,6 +82,7 @@ int misc_init_r(void)
>  
>  	return 0;
>  }
> +#endif
>  
>  int dram_init(void)
>  {

Amicalement,

Patch

diff --git a/board/highbank/highbank.c b/board/highbank/highbank.c
index 4cc4b1c..82ebeea 100644
--- a/board/highbank/highbank.c
+++ b/board/highbank/highbank.c
@@ -60,6 +60,7 @@  int board_eth_init(bd_t *bis)
 	return rc;
 }
 
+#ifdef CONFIG_MISC_INIT_R
 int misc_init_r(void)
 {
 	char envbuffer[16];
@@ -81,6 +82,7 @@  int misc_init_r(void)
 
 	return 0;
 }
+#endif
 
 int dram_init(void)
 {