Patchwork [U-Boot,v4,1/9] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263

login
register
mail settings
Submitter Simon Glass
Date May 15, 2013, 4:23 p.m.
Message ID <1368635041-27638-1-git-send-email-sjg@chromium.org>
Download mbox | patch
Permalink /patch/244131/
State Accepted, archived
Delegated to: Tom Rini
Headers show

Comments

Simon Glass - May 15, 2013, 4:23 p.m.
This is not currently used, since autoboot is not enabled for this
board, but the string is missing a parameter. Add it.


Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v4: None
Changes in v3: None

 include/configs/pm9263.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Andreas Bießmann - May 17, 2013, 6:06 a.m.
Hi Simon,

On 15.05.13 18:23, Simon Glass wrote:
> This is not currently used, since autoboot is not enabled for this
> board, but the string is missing a parameter. Add it.
> 
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Acked-by: Andreas Bießmann <andreas.devel@googlemail.com>
> ---
> Changes in v4: None
> Changes in v3: None
> 
>  include/configs/pm9263.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/pm9263.h b/include/configs/pm9263.h
> index b60a9ad..6f6ddfa 100644
> --- a/include/configs/pm9263.h
> +++ b/include/configs/pm9263.h
> @@ -355,7 +355,7 @@
>  
>  #define CONFIG_BOOTCOMMAND		"run flashboot"
>  #define CONFIG_ROOTPATH			"/ronetix/rootfs"
> -#define CONFIG_AUTOBOOT_PROMPT		"autoboot in %d seconds\n"
> +#define CONFIG_AUTOBOOT_PROMPT		"autoboot in %d seconds\n", bootdelay
>  
>  #define CONFIG_CON_ROT			"fbcon=rotate:3 "
>  #define CONFIG_BOOTARGS			"root=/dev/mtdblock4 rootfstype=jffs2 "\
>
Tom Rini - June 5, 2013, 12:33 p.m.
On Wed, May 15, 2013 at 09:23:53AM -0700, Simon Glass wrote:

> This is not currently used, since autoboot is not enabled for this
> board, but the string is missing a parameter. Add it.
> 
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Along with the rest of the series, applied to u-boot/master, thanks!

Patch

diff --git a/include/configs/pm9263.h b/include/configs/pm9263.h
index b60a9ad..6f6ddfa 100644
--- a/include/configs/pm9263.h
+++ b/include/configs/pm9263.h
@@ -355,7 +355,7 @@ 
 
 #define CONFIG_BOOTCOMMAND		"run flashboot"
 #define CONFIG_ROOTPATH			"/ronetix/rootfs"
-#define CONFIG_AUTOBOOT_PROMPT		"autoboot in %d seconds\n"
+#define CONFIG_AUTOBOOT_PROMPT		"autoboot in %d seconds\n", bootdelay
 
 #define CONFIG_CON_ROT			"fbcon=rotate:3 "
 #define CONFIG_BOOTARGS			"root=/dev/mtdblock4 rootfstype=jffs2 "\