Message ID | 1368607606-4344-3-git-send-email-b32955@freescale.com |
---|---|
State | New, archived |
Headers | show |
On Wed, May 15, 2013 at 04:46:44PM +0800, Huang Shijie wrote: > Add a new sys node to show the ecc step size. > The application then can uses this node to get the ecc step > size. > > Signed-off-by: Huang Shijie <b32955@freescale.com> > --- > drivers/mtd/mtdcore.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index c400c57..63903b9 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -285,6 +285,16 @@ static DEVICE_ATTR(bitflip_threshold, S_IRUGO | S_IWUSR, > mtd_bitflip_threshold_show, > mtd_bitflip_threshold_store); > > +static ssize_t mtd_ecc_step_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct mtd_info *mtd = dev_get_drvdata(dev); > + > + return snprintf(buf, PAGE_SIZE, "%lu\n", (unsigned long)mtd->ecc_step); ecc_step is an unsigned int, so why cast to unsigned long? Just use: return snprintf(buf, PAGE_SIZE, "%u\n", mtd->ecc_step); > + > +} > +static DEVICE_ATTR(ecc_step, S_IRUGO, mtd_ecc_step_show, NULL); > + > static struct attribute *mtd_attrs[] = { > &dev_attr_type.attr, > &dev_attr_flags.attr, ... Brian
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index c400c57..63903b9 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -285,6 +285,16 @@ static DEVICE_ATTR(bitflip_threshold, S_IRUGO | S_IWUSR, mtd_bitflip_threshold_show, mtd_bitflip_threshold_store); +static ssize_t mtd_ecc_step_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct mtd_info *mtd = dev_get_drvdata(dev); + + return snprintf(buf, PAGE_SIZE, "%lu\n", (unsigned long)mtd->ecc_step); + +} +static DEVICE_ATTR(ecc_step, S_IRUGO, mtd_ecc_step_show, NULL); + static struct attribute *mtd_attrs[] = { &dev_attr_type.attr, &dev_attr_flags.attr, @@ -296,6 +306,7 @@ static struct attribute *mtd_attrs[] = { &dev_attr_numeraseregions.attr, &dev_attr_name.attr, &dev_attr_ecc_strength.attr, + &dev_attr_ecc_step.attr, &dev_attr_bitflip_threshold.attr, NULL, };
Add a new sys node to show the ecc step size. The application then can uses this node to get the ecc step size. Signed-off-by: Huang Shijie <b32955@freescale.com> --- drivers/mtd/mtdcore.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)