From patchwork Wed May 15 11:46:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Klose X-Patchwork-Id: 244048 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id E8DD82C00A4 for ; Wed, 15 May 2013 21:46:34 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=wuq6LbzknhPPsB6/e a8s5Uyq/pO/VYZMVWX6yFD1g5S79A3/D0LG2yxGozsU1ZxXasmoXe50TPSVTUdUz XkZw9eFJpEeAYqIczlsmwKcjDONcMPA6IAqmP15NQ7NOIdlUppML57biQhZJuzQ7 rPOAkgvOYxg3qAl8gfALzqUklA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=GvnaC9f4cYxAzIPyq1suTZt sGYw=; b=wUfQFLGs48vf0eGRultbl08Sxr1iMsWsBRrRfpTMsquHwoQENWpdhYt ID2fRsyUuwMaUvZE5pwb96FEXiISNipvDdDJXp6ZNONsqS7012hXkujQRiYcniJ9 5cgnAinSnFWBEM2B1ZFKkUlY9d21/O4VdH1ZNcquKMV1ewEMTmcM= Received: (qmail 21497 invoked by alias); 15 May 2013 11:46:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21487 invoked by uid 89); 15 May 2013 11:46:25 -0000 X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, TW_SX autolearn=ham version=3.3.1 Received: from youngberry.canonical.com (HELO youngberry.canonical.com) (91.189.89.112) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 11:46:23 +0000 Received: from dslb-088-073-076-134.pools.arcor-ip.net ([88.73.76.134] helo=[192.168.42.222]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1UcaA1-0007R3-3y; Wed, 15 May 2013 11:46:21 +0000 Message-ID: <5193758A.7020103@ubuntu.com> Date: Wed, 15 May 2013 13:46:18 +0200 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Wookey , Alexandre Oliva , ian@airs.com Subject: [ping] Re: [PATCH] Remove unnecessaily included limits.h in libgcc2.c References: <20130104190058.GP9131@stoneboat.aleph1.co.uk> <50F47E7E.7090307@ubuntu.com> In-Reply-To: <50F47E7E.7090307@ubuntu.com> X-Virus-Found: No ping? regenerated the patch for the trunk, check with builds on arm-linux-gnueabihf and x86_64-linux-gnu Matthias * libgcc2.c: Don't include . Am 14.01.2013 22:54, schrieb Matthias Klose: > Am 04.01.2013 20:01, schrieb Wookey: >> I filed http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55743 (my first >> upstream gcc bug so be gentle :-) >> >> Details are there but the short version is that the limits.h inclusion >> in libgcc2.c is now a relic because the constants that it brings >> in are no longer used (since >> http://repo.or.cz/w/official-gcc.git/blobdiff/49f0f270673c4512c11f72a038b84c321ae5534a..7429c938827aa98bf3b02c4ac89510f4d28ef0b1:/gcc/libgcc2.c >> ) >> >> And this inclusion can break --without-headers bootstrapping (which is >> how I noticed it). >> >> Doko poked me to send the patch to this list for consideration for >> inclusion in trunk. > > The --without-headers build failures is unrelated. To catch this > mis-configuration I did propose a patch in > http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00743.html > > I think the patch itself is correct. However > > - please submit your patch against trunk, and state that you > did test the patch against trunk (of course, after testing it) > > - please provide a ChangeLog entry > > - thanks for your reference to the repo.or.cz repo, however it > would be good to reference a GCC commit. > looks like Alexandre Oliva did commit this without removing > the unneeded bits in r39365. > > Matthias > > Index: libgcc/libgcc2.c =================================================================== --- libgcc/libgcc2.c (revision 198927) +++ libgcc/libgcc2.c (working copy) @@ -1674,18 +1674,6 @@ #endif #if defined(L_fixunsxfsi) && LIBGCC2_HAS_XF_MODE -/* Reenable the normal types, in case limits.h needs them. */ -#undef char -#undef short -#undef int -#undef long -#undef unsigned -#undef float -#undef double -#undef MIN -#undef MAX -#include - UWtype __fixunsxfSI (XFtype a) { @@ -1696,18 +1684,6 @@ #endif #if defined(L_fixunsdfsi) && LIBGCC2_HAS_DF_MODE -/* Reenable the normal types, in case limits.h needs them. */ -#undef char -#undef short -#undef int -#undef long -#undef unsigned -#undef float -#undef double -#undef MIN -#undef MAX -#include - UWtype __fixunsdfSI (DFtype a) { @@ -1718,18 +1694,6 @@ #endif #if defined(L_fixunssfsi) && LIBGCC2_HAS_SF_MODE -/* Reenable the normal types, in case limits.h needs them. */ -#undef char -#undef short -#undef int -#undef long -#undef unsigned -#undef float -#undef double -#undef MIN -#undef MAX -#include - UWtype __fixunssfSI (SFtype a) {