From patchwork Tue May 14 21:53:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 243848 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 20F7B2C00A8 for ; Wed, 15 May 2013 08:02:16 +1000 (EST) Received: from localhost ([::1]:46424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcNIU-0000jj-Bd for incoming@patchwork.ozlabs.org; Tue, 14 May 2013 18:02:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcNCV-0007QZ-QR for qemu-devel@nongnu.org; Tue, 14 May 2013 17:56:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcNCU-0003zg-RU for qemu-devel@nongnu.org; Tue, 14 May 2013 17:56:03 -0400 Received: from mail-ie0-x22b.google.com ([2607:f8b0:4001:c03::22b]:61088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcNCU-0003zZ-L7; Tue, 14 May 2013 17:56:02 -0400 Received: by mail-ie0-f171.google.com with SMTP id e11so2223082iej.16 for ; Tue, 14 May 2013 14:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=3iQ4r7/13dLKWNFTCMrEtxk0OWdogu2S2GHX8FKydt0=; b=fc7PBX1Xbx6ePWp6MYOOT3SU6DzOTyFkYkF1+yzpvxHs5xOXcHuTXMogrB7KQXctJV x0J44WVt+Q3HtH4US1ueULCaJOFLYr5xiQFcCQp4LN01EnVcgzMyLojhm/KqbVigquyH FGzxzbANKx08tKRM5ZG0c+Uwq+byNfQrTtS39mVd6JD8JQkkWZPd+GCnW4BhL050yaJ0 jGCOoXorYvaWlf9c1AfAt3QJUTtAD703k9OEAob9QIjpF6tld3UhF5wzcYjgKng//ClY y5033dq/nALKRFAEbswvIfcTMMxrK6ZP3dYK8WpVs6axr9KXuatJSDKFGVqFZLl2ct44 SryQ== X-Received: by 10.50.100.201 with SMTP id fa9mr3442222igb.28.1368568562123; Tue, 14 May 2013 14:56:02 -0700 (PDT) Received: from localhost (cpe-72-177-121-217.austin.res.rr.com. [72.177.121.217]) by mx.google.com with ESMTPSA id wx2sm218800igb.4.2013.05.14.14.56.00 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 14 May 2013 14:56:01 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 14 May 2013 16:53:12 -0500 Message-Id: <1368568392-2127-16-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1368568392-2127-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1368568392-2127-1-git-send-email-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::22b Cc: aliguori@us.ibm.com, qemu-stable@nongnu.org Subject: [Qemu-devel] [PATCH 15/15] qga: unlink just created guest-file if fchmod() or fdopen() fails on it X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Laszlo Ersek We shouldn't allow guest filesystem pollution on error paths. Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino Signed-off-by: Michael Roth (cherry picked from commit 2b720018060179b394f8ce736983373ab80dd37c) Signed-off-by: Michael Roth --- qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 933c700..e439851 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -277,6 +277,9 @@ safe_open_or_create(const char *path, const char *mode, Error **err) } close(fd); + if (oflag & O_CREAT) { + unlink(path); + } } }