From patchwork Tue May 14 19:09:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 243803 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 4ACBE2C0095 for ; Wed, 15 May 2013 05:09:53 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :content-type:subject:message-id:date:to:mime-version; q=dns; s= default; b=p1hsx5YVQgW1a4zVhKjE7yVCWRKLid5Iz+A2Rbt1HnlcIpX+xNZjK qWk5yeW6kES9Prc/gHUsmbCOv1SYNlhJXdipwZ/HCuxFVavTTjPl9xr9u7xau2K9 q0SPC+GKuZ8s5EMYXkHBku/4j6z0PYUpRAhnZabsTZok3sykEXWqz4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :content-type:subject:message-id:date:to:mime-version; s= default; bh=xBZuQB5Or7eGBHNOfUk6pZruABk=; b=Y4CRIG7oO9GFdG+MJFGr XTwjxaOqABilQ9NBZv8jyZm1GpYftl6DBPIFD415RHBmZB4A34kwDN5Dq25Hx5zQ 1qKlcjojgzScLimhFw1CzEB0Wm8y4vwC4r6pmEcU7G0bzzTKtOF6iYlz1RO/+7Xd WPPdzZNjqexAyNlI5D+7bcU= Received: (qmail 27192 invoked by alias); 14 May 2013 19:09:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 27182 invoked by uid 89); 14 May 2013 19:09:47 -0000 X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_NO, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, SPF_PASS, TW_CP autolearn=ham version=3.3.1 Received: from qmta05.emeryville.ca.mail.comcast.net (HELO qmta05.emeryville.ca.mail.comcast.net) (76.96.30.48) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 14 May 2013 19:09:46 +0000 Received: from omta15.emeryville.ca.mail.comcast.net ([76.96.30.71]) by qmta05.emeryville.ca.mail.comcast.net with comcast id bupw1l0021Y3wxoA5v9l9o; Tue, 14 May 2013 19:09:45 +0000 Received: from bag6-1-pt.tunnel.tserv3.fmt2.ipv6.he.net ([IPv6:2001:470:1f04:ae1::2]) by omta15.emeryville.ca.mail.comcast.net with comcast id bv9k1l00R0P3DwE8bv9kK7; Tue, 14 May 2013 19:09:45 +0000 From: Mike Stump Subject: debuggability of recog_data Message-Id: Date: Tue, 14 May 2013 12:09:44 -0700 To: "gcc-patches@gcc.gnu.org List" Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) X-Virus-Found: No Here is a trivial patch that improves the debuggability of recog_data. Without this p recog_data in gdb on linux, didn't seem to work at all. My fingers were not amused. :-) Checked it in a obvious. 2013-05-14 Mike Stump * recog.h: Rename struct recog_data to Recog_data. * recog.c: Likewise. * reload.c (can_reload_into): Likewise. * config/picochip/picochip.c: Likewise. ------------------------------ Index: config/picochip/picochip.c =================================================================== --- config/picochip/picochip.c (revision 198896) +++ config/picochip/picochip.c (working copy) @@ -187,7 +187,7 @@ struct vliw_state picochip_current_vliw_ /* Save/restore recog_data. */ static int picochip_saved_which_alternative; -static struct recog_data picochip_saved_recog_data; +static struct Recog_data picochip_saved_recog_data; /* Determine which ALU to use for the instruction in picochip_current_prescan_insn. */ @@ -3150,7 +3150,7 @@ picochip_save_recog_data (void) { picochip_saved_which_alternative = which_alternative; memcpy (&picochip_saved_recog_data, &recog_data, - sizeof (struct recog_data)); + sizeof (struct Recog_data)); } /* Restore some of the contents of global variable recog_data. */ @@ -3159,7 +3159,7 @@ picochip_restore_recog_data (void) { which_alternative = picochip_saved_which_alternative; memcpy (&recog_data, &picochip_saved_recog_data, - sizeof (struct recog_data)); + sizeof (struct Recog_data)); } /* Ensure that no var tracking notes are emitted in the middle of a Index: recog.c =================================================================== --- recog.c (revision 198896) +++ recog.c (working copy) @@ -70,7 +70,7 @@ static rtx split_insn (rtx); int volatile_ok; -struct recog_data recog_data; +struct Recog_data recog_data; /* Contains a vector of operand_alternative structures for every operand. Set up by preprocess_constraints. */ Index: recog.h =================================================================== --- recog.h (revision 198896) +++ recog.h (working copy) @@ -179,7 +179,7 @@ extern int which_alternative; /* The following vectors hold the results from insn_extract. */ -struct recog_data +struct Recog_data { /* It is very tempting to make the 5 operand related arrays into a structure and index on that. However, to be source compatible @@ -245,7 +245,7 @@ struct recog_data rtx insn; }; -extern struct recog_data recog_data; +extern struct Recog_data recog_data; /* Contains a vector of operand_alternative structures for every operand. Set up by preprocess_constraints. */ Index: reload.c =================================================================== --- reload.c (revision 198896) +++ reload.c (working copy) @@ -895,7 +895,7 @@ can_reload_into (rtx in, int regno, enum { rtx dst, test_insn; int r = 0; - struct recog_data save_recog_data; + struct Recog_data save_recog_data; /* For matching constraints, we often get notional input reloads where we want to use the original register as the reload register. I.e.