Patchwork [8/9] data: klog.json: Drop ACPI prefix, make patten a string match

login
register
mail settings
Submitter Colin King
Date May 14, 2013, 2 p.m.
Message ID <1368540031-28500-9-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/243716/
State Accepted
Headers show

Comments

Colin King - May 14, 2013, 2 p.m.
From: Colin Ian King <colin.king@canonical.com>

No need for the leading ACPI prefix, drop it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Keng-Yu Lin - May 20, 2013, 8:33 a.m.
On Tue, May 14, 2013 at 10:00 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> No need for the leading ACPI prefix, drop it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index d112b86..4b56f04 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3995,11 +3995,11 @@
>     "label": "KlogAcpiNoHandlerForRegion"
>    },
>    {
> -   "compare_mode": "regex",
> +   "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_NO_HANDLER",
> -   "pattern": "ACPI Error.*No handler for Region",
> -   "advice": "",
> +   "pattern": "No handler for Region",
> +   "advice": "ACPI attempted to read or write to a region however the ACPI driver does not have a handler implemented for this particular region space.  The read/write will fail and undefined behaviour will occur.",
>     "label": "KlogAcpiNoHandlerForRegion"
>    },
>    {
> --
> 1.8.1.2
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - May 21, 2013, 6:09 a.m.
On 05/14/2013 10:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> No need for the leading ACPI prefix, drop it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index d112b86..4b56f04 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3995,11 +3995,11 @@
>      "label": "KlogAcpiNoHandlerForRegion"
>     },
>     {
> -   "compare_mode": "regex",
> +   "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_NO_HANDLER",
> -   "pattern": "ACPI Error.*No handler for Region",
> -   "advice": "",
> +   "pattern": "No handler for Region",
> +   "advice": "ACPI attempted to read or write to a region however the ACPI driver does not have a handler implemented for this particular region space.  The read/write will fail and undefined behaviour will occur.",
>      "label": "KlogAcpiNoHandlerForRegion"
>     },
>     {
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index d112b86..4b56f04 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -3995,11 +3995,11 @@ 
    "label": "KlogAcpiNoHandlerForRegion"
   },
   {
-   "compare_mode": "regex",
+   "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_NO_HANDLER",
-   "pattern": "ACPI Error.*No handler for Region",
-   "advice": "",
+   "pattern": "No handler for Region",
+   "advice": "ACPI attempted to read or write to a region however the ACPI driver does not have a handler implemented for this particular region space.  The read/write will fail and undefined behaviour will occur.",
    "label": "KlogAcpiNoHandlerForRegion"
   },
   {