Patchwork [1/9] data: klog.json: Add ACPI video notify handler check

login
register
mail settings
Submitter Colin King
Date May 14, 2013, 2 p.m.
Message ID <1368540031-28500-2-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/243713/
State Accepted
Headers show

Comments

Colin King - May 14, 2013, 2 p.m.
From: Colin Ian King <colin.king@canonical.com>

Check for ACPI video notify handler install failure message.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 8 ++++++++
 1 file changed, 8 insertions(+)
Keng-Yu Lin - May 20, 2013, 8:23 a.m.
On Tue, May 14, 2013 at 10:00 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Check for ACPI video notify handler install failure message.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index ec25a2c..44d5a9c 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -77,6 +77,14 @@
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
> +    "pattern": "Error installing notify handler",
> +    "advice": "Failed to install a notify handler for the ACPI video driver. The ACPI video driver cannot handle notify events to change brightness levels or turn the display on/off.",
> +    "label": "KlogAcpiNotifyHandlerInstallFailed"
> +  },
> +  {
> +    "compare_mode": "string",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "tag": "FWTS_TAG_ACPI",
>      "pattern": "Could not register bus type",
>      "advice": "The ACPI driver failed to register the ACPI buse type.  This is not deemed to be fatal, but it is a kernel error that should be investigated. See acpi_scan_init().",
>      "label": "KlogAcpiScanBusTypeRegisterFailed"
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - May 21, 2013, 6:08 a.m.
On 05/14/2013 10:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Check for ACPI video notify handler install failure message.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index ec25a2c..44d5a9c 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -77,6 +77,14 @@
>       "compare_mode": "string",
>       "log_level": "LOG_LEVEL_HIGH",
>       "tag": "FWTS_TAG_ACPI",
> +    "pattern": "Error installing notify handler",
> +    "advice": "Failed to install a notify handler for the ACPI video driver. The ACPI video driver cannot handle notify events to change brightness levels or turn the display on/off.",
> +    "label": "KlogAcpiNotifyHandlerInstallFailed"
> +  },
> +  {
> +    "compare_mode": "string",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "tag": "FWTS_TAG_ACPI",
>       "pattern": "Could not register bus type",
>       "advice": "The ACPI driver failed to register the ACPI buse type.  This is not deemed to be fatal, but it is a kernel error that should be investigated. See acpi_scan_init().",
>       "label": "KlogAcpiScanBusTypeRegisterFailed"
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index ec25a2c..44d5a9c 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -77,6 +77,14 @@ 
     "compare_mode": "string",
     "log_level": "LOG_LEVEL_HIGH",
     "tag": "FWTS_TAG_ACPI",
+    "pattern": "Error installing notify handler",
+    "advice": "Failed to install a notify handler for the ACPI video driver. The ACPI video driver cannot handle notify events to change brightness levels or turn the display on/off.",
+    "label": "KlogAcpiNotifyHandlerInstallFailed"
+  },
+  {
+    "compare_mode": "string",
+    "log_level": "LOG_LEVEL_HIGH",
+    "tag": "FWTS_TAG_ACPI",
     "pattern": "Could not register bus type",
     "advice": "The ACPI driver failed to register the ACPI buse type.  This is not deemed to be fatal, but it is a kernel error that should be investigated. See acpi_scan_init().",
     "label": "KlogAcpiScanBusTypeRegisterFailed"