Patchwork [9/9] data: klog.json: Bit offset pattern should be a regex not a string match

login
register
mail settings
Submitter Colin King
Date May 14, 2013, 2 p.m.
Message ID <1368540031-28500-10-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/243712/
State Accepted
Headers show

Comments

Colin King - May 14, 2013, 2 p.m.
From: Colin Ian King <colin.king@canonical.com>

Fix bug where we were scanning for a string rather than a regex pattern

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - May 20, 2013, 8:34 a.m.
On Tue, May 14, 2013 at 10:00 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fix bug where we were scanning for a string rather than a regex pattern
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 4b56f04..b50449f 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -1170,7 +1170,7 @@
>      "label": "KlogAcpiAttachNullObjectBadType"
>    },
>    {
> -    "compare_mode": "string",
> +    "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "Bit offset within field too large.*0xFFFFFFFF",
> --
> 1.8.1.2
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - May 21, 2013, 6:09 a.m.
On 05/14/2013 10:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fix bug where we were scanning for a string rather than a regex pattern
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 4b56f04..b50449f 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -1170,7 +1170,7 @@
>       "label": "KlogAcpiAttachNullObjectBadType"
>     },
>     {
> -    "compare_mode": "string",
> +    "compare_mode": "regex",
>       "log_level": "LOG_LEVEL_HIGH",
>       "tag": "FWTS_TAG_ACPI",
>       "pattern": "Bit offset within field too large.*0xFFFFFFFF",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 4b56f04..b50449f 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -1170,7 +1170,7 @@ 
     "label": "KlogAcpiAttachNullObjectBadType"
   },
   {
-    "compare_mode": "string",
+    "compare_mode": "regex",
     "log_level": "LOG_LEVEL_HIGH",
     "tag": "FWTS_TAG_ACPI",
     "pattern": "Bit offset within field too large.*0xFFFFFFFF",