Patchwork [6/9] data: klog.json: Add ACPI fixed event error checking

login
register
mail settings
Submitter Colin King
Date May 14, 2013, 2 p.m.
Message ID <1368540031-28500-7-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/243711/
State Accepted
Headers show

Comments

Colin King - May 14, 2013, 2 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Keng-Yu Lin - May 20, 2013, 8:29 a.m.
On Tue, May 14, 2013 at 10:00 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 381e8c1..6fb3b82 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -74,6 +74,22 @@
>     "label": "CommonBiosIrqRoutingBug"
>    },
>    {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "tag": "FWTS_TAG_ACPI",
> +    "pattern": "Could not enable.*event",
> +    "advice": "An ACPI fixed event could not be enabled. This can affect fixed events such as the power management timer, power button, sleep button, RTC alarm, wake status, system bus master request or the global release lock status.",
> +    "label": "KlogAcpiEventEnableFailed"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "tag": "FWTS_TAG_ACPI",
> +    "pattern": "Could not disable.*events",
> +    "advice": "An ACPI fixed event could not be disabled. This can affect fixed events such as the power management timer, power button, sleep button, RTC alarm, wake status, system bus master request or the global release lock status.",
> +    "label": "KlogAcpiEventDisableFailed"
> +  },
> +  {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
> --
> 1.8.1.2
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - May 21, 2013, 6:08 a.m.
On 05/14/2013 10:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 381e8c1..6fb3b82 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -74,6 +74,22 @@
>      "label": "CommonBiosIrqRoutingBug"
>     },
>     {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "tag": "FWTS_TAG_ACPI",
> +    "pattern": "Could not enable.*event",
> +    "advice": "An ACPI fixed event could not be enabled. This can affect fixed events such as the power management timer, power button, sleep button, RTC alarm, wake status, system bus master request or the global release lock status.",
> +    "label": "KlogAcpiEventEnableFailed"
> +  },
> +  {
> +    "compare_mode": "regex",
> +    "log_level": "LOG_LEVEL_HIGH",
> +    "tag": "FWTS_TAG_ACPI",
> +    "pattern": "Could not disable.*events",
> +    "advice": "An ACPI fixed event could not be disabled. This can affect fixed events such as the power management timer, power button, sleep button, RTC alarm, wake status, system bus master request or the global release lock status.",
> +    "label": "KlogAcpiEventDisableFailed"
> +  },
> +  {
>       "compare_mode": "string",
>       "log_level": "LOG_LEVEL_HIGH",
>       "tag": "FWTS_TAG_ACPI",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 381e8c1..6fb3b82 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -74,6 +74,22 @@ 
    "label": "CommonBiosIrqRoutingBug"
   },
   {
+    "compare_mode": "regex",
+    "log_level": "LOG_LEVEL_HIGH",
+    "tag": "FWTS_TAG_ACPI",
+    "pattern": "Could not enable.*event",
+    "advice": "An ACPI fixed event could not be enabled. This can affect fixed events such as the power management timer, power button, sleep button, RTC alarm, wake status, system bus master request or the global release lock status.",
+    "label": "KlogAcpiEventEnableFailed"
+  },
+  {
+    "compare_mode": "regex",
+    "log_level": "LOG_LEVEL_HIGH",
+    "tag": "FWTS_TAG_ACPI",
+    "pattern": "Could not disable.*events",
+    "advice": "An ACPI fixed event could not be disabled. This can affect fixed events such as the power management timer, power button, sleep button, RTC alarm, wake status, system bus master request or the global release lock status.",
+    "label": "KlogAcpiEventDisableFailed"
+  },
+  {
     "compare_mode": "string",
     "log_level": "LOG_LEVEL_HIGH",
     "tag": "FWTS_TAG_ACPI",