[v2] jbd2: Always set journal superblock checksum when writing out superblock

Message ID 20130513214940.GC8037@blackbox.djwong.org
State Superseded, archived
Headers show

Commit Message

Darrick J. Wong May 13, 2013, 9:49 p.m.
Avoid future programming errors by making it so that the journal superblock
checksum is set in jbd2_write_superblock.  This fixes some journal checksum
failures when metadata_csum is turned on.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
 fs/jbd2/journal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 4576bec..85550bf 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1325,6 +1325,7 @@  static void jbd2_write_superblock(journal_t *journal, int write_op)
 	if (!(journal->j_flags & JBD2_BARRIER))
 		write_op &= ~(REQ_FUA | REQ_FLUSH);
+	jbd2_superblock_csum_set(journal, journal->j_superblock);
 	if (buffer_write_io_error(bh)) {
 		 * Oh, dear.  A previous attempt to write the journal
@@ -1436,7 +1437,6 @@  void jbd2_journal_update_sb_errno(journal_t *journal)
 	jbd_debug(1, "JBD2: updating superblock error (errno %d)\n",
 	sb->s_errno    = cpu_to_be32(journal->j_errno);
-	jbd2_superblock_csum_set(journal, sb);
 	jbd2_write_superblock(journal, WRITE_SYNC);