Patchwork [v2] vfio-pci: Add support for MSI affinity

login
register
mail settings
Submitter Alex Williamson
Date May 13, 2013, 8:17 p.m.
Message ID <20130513201623.5326.54179.stgit@bling.home>
Download mbox | patch
Permalink /patch/243522/
State New
Headers show

Comments

Alex Williamson - May 13, 2013, 8:17 p.m.
When MSI is accelerated through KVM the vectors are only programmed
when the guest first enables MSI support.  Subsequent writes to the
vector address or data fields are ignored.  Unfortunately that means
wee ignore updates done to adjust SMP affinity of the vectors.  MSI
SMP affinity already works in non-KVM mode because the address and
data fields are read from their backing store on each interrupt.

Update the message any time the address or data fields are written.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

v2: Don't cache MSIMessage, therefore filter only address/data writes

 hw/misc/vfio.c |   42 ++++++++++++++++++++++++++++++++++--------
 1 file changed, 34 insertions(+), 8 deletions(-)

Patch

diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 693a9ff..46b3be4 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -163,6 +163,7 @@  typedef struct VFIODevice {
 #define VFIO_FEATURE_ENABLE_VGA (1 << VFIO_FEATURE_ENABLE_VGA_BIT)
     int32_t bootindex;
     uint8_t pm_cap;
+    bool msi_64bit;
     bool reset_works;
     bool has_vga;
 } VFIODevice;
@@ -898,6 +899,22 @@  static void vfio_disable_msi(VFIODevice *vdev)
             vdev->host.bus, vdev->host.slot, vdev->host.function);
 }
 
+static void vfio_update_msi(VFIODevice *vdev)
+{
+    int i;
+
+    for (i = 0; i < vdev->nr_vectors; i++) {
+        VFIOMSIVector *vector = &vdev->msi_vectors[i];
+
+        if (!vector->use || vector->virq < 0) {
+            continue;
+        }
+
+        kvm_irqchip_update_msi_route(kvm_state, vector->virq,
+                                     msi_get_message(&vdev->pdev, i));
+    }
+}
+
 /*
  * IO Port/MMIO - Beware of the endians, VFIO is always little endian
  */
@@ -1850,10 +1867,18 @@  static void vfio_pci_write_config(PCIDevice *pdev, uint32_t addr,
 
         is_enabled = msi_enabled(pdev);
 
-        if (!was_enabled && is_enabled) {
-            vfio_enable_msi(vdev);
-        } else if (was_enabled && !is_enabled) {
-            vfio_disable_msi(vdev);
+        if (!was_enabled) {
+            if (is_enabled) {
+                vfio_enable_msi(vdev);
+            }
+        } else {
+            if (!is_enabled) {
+                vfio_disable_msi(vdev);
+            } else if (ranges_overlap(addr, len,
+                                      pdev->msi_cap + PCI_MSI_ADDRESS_LO,
+                                      2 + (vdev->msi_64bit ? 8 : 4))) {
+                vfio_update_msi(vdev);
+            }
         }
     } else if (pdev->cap_present & QEMU_PCI_CAP_MSIX &&
         ranges_overlap(addr, len, pdev->msix_cap, MSIX_CAP_LENGTH)) {
@@ -2046,7 +2071,7 @@  static void vfio_disable_interrupts(VFIODevice *vdev)
 static int vfio_setup_msi(VFIODevice *vdev, int pos)
 {
     uint16_t ctrl;
-    bool msi_64bit, msi_maskbit;
+    bool msi_maskbit;
     int ret, entries;
 
     if (pread(vdev->fd, &ctrl, sizeof(ctrl),
@@ -2055,14 +2080,14 @@  static int vfio_setup_msi(VFIODevice *vdev, int pos)
     }
     ctrl = le16_to_cpu(ctrl);
 
-    msi_64bit = !!(ctrl & PCI_MSI_FLAGS_64BIT);
+    vdev->msi_64bit = !!(ctrl & PCI_MSI_FLAGS_64BIT);
     msi_maskbit = !!(ctrl & PCI_MSI_FLAGS_MASKBIT);
     entries = 1 << ((ctrl & PCI_MSI_FLAGS_QMASK) >> 1);
 
     DPRINTF("%04x:%02x:%02x.%x PCI MSI CAP @0x%x\n", vdev->host.domain,
             vdev->host.bus, vdev->host.slot, vdev->host.function, pos);
 
-    ret = msi_init(&vdev->pdev, pos, entries, msi_64bit, msi_maskbit);
+    ret = msi_init(&vdev->pdev, pos, entries, vdev->msi_64bit, msi_maskbit);
     if (ret < 0) {
         if (ret == -ENOTSUP) {
             return 0;
@@ -2070,7 +2095,8 @@  static int vfio_setup_msi(VFIODevice *vdev, int pos)
         error_report("vfio: msi_init failed");
         return ret;
     }
-    vdev->msi_cap_size = 0xa + (msi_maskbit ? 0xa : 0) + (msi_64bit ? 0x4 : 0);
+    vdev->msi_cap_size = 0xa + (msi_maskbit ? 0xa : 0) +
+                         (vdev->msi_64bit ? 0x4 : 0);
 
     return 0;
 }