Patchwork [08/15] drivers/rtc/rtc-lp8788.c: Remove empty function

login
register
mail settings
Submitter Sachin Kamat
Date May 13, 2013, 11:48 a.m.
Message ID <1368445693-24639-8-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/243387/
State New
Headers show

Comments

Sachin Kamat - May 13, 2013, 11:48 a.m.
'remove' function does not do anything. Hence delete it.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Milo(Woogyom) Kim <milo.kim@ti.com>
---
 drivers/rtc/rtc-lp8788.c |    6 ------
 1 file changed, 6 deletions(-)
Kim, Milo - May 13, 2013, 12:31 p.m.
Hi Sachin,

> -----Original Message-----
> From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
> Sent: Monday, May 13, 2013 8:48 PM
> To: rtc-linux@googlegroups.com
> Cc: a.zummo@towertech.it; akpm@linux-foundation.org;
> sachin.kamat@linaro.org; Kim, Milo
> Subject: [PATCH 08/15] drivers/rtc/rtc-lp8788.c: Remove empty function
> 
> 'remove' function does not do anything. Hence delete it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
>  drivers/rtc/rtc-lp8788.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-lp8788.c b/drivers/rtc/rtc-lp8788.c
> index 76a82dc..4ff6c73 100644
> --- a/drivers/rtc/rtc-lp8788.c
> +++ b/drivers/rtc/rtc-lp8788.c
> @@ -312,14 +312,8 @@ static int lp8788_rtc_probe(struct platform_device
> *pdev)
>  	return 0;
>  }
> 
> -static int lp8788_rtc_remove(struct platform_device *pdev)
> -{
> -	return 0;
> -}
> -
>  static struct platform_driver lp8788_rtc_driver = {
>  	.probe = lp8788_rtc_probe,
> -	.remove = lp8788_rtc_remove,
>  	.driver = {
>  		.name = LP8788_DEV_RTC,
>  		.owner = THIS_MODULE,

I just wondered why this remove() function is so useless, but I just found that 
rtc_device_unregister() was removed in previous patch by using devm_ function.
I didn't notice that. Thanks for catching this and a good reminder.

Acked-by: Milo Kim <milo.kim@ti.com>

Patch

diff --git a/drivers/rtc/rtc-lp8788.c b/drivers/rtc/rtc-lp8788.c
index 76a82dc..4ff6c73 100644
--- a/drivers/rtc/rtc-lp8788.c
+++ b/drivers/rtc/rtc-lp8788.c
@@ -312,14 +312,8 @@  static int lp8788_rtc_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int lp8788_rtc_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
 static struct platform_driver lp8788_rtc_driver = {
 	.probe = lp8788_rtc_probe,
-	.remove = lp8788_rtc_remove,
 	.driver = {
 		.name = LP8788_DEV_RTC,
 		.owner = THIS_MODULE,