| Message ID | 1368299031-17587-1-git-send-email-hpoussin@reactos.org |
|---|---|
| State | New |
| Headers | show |
Ping. This should be IMO committed to stable, as it fixes a crash with qemu-system-ppc -M prep -cpu 603e Hervé Hervé Poussineau a écrit : > IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). > > Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> > --- > target-ppc/translate_init.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 6feb62a..248d3e0 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env) > SPR_NOACCESS, SPR_NOACCESS, > &spr_read_generic, &spr_write_generic, > 0x00000000); > - /* XXX : not implemented */ > - spr_register(env, SPR_IABR, "IABR", > - SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > - 0x00000000); > /* Memory management */ > gen_low_BATs(env); > gen_6xx_7xx_soft_tlb(env, 64, 2);
On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote: > Ping. > This should be IMO committed to stable, as it fixes a crash with > qemu-system-ppc -M prep -cpu 603e Ping^2. Looking to pull this in for 1.5.1 > > Hervé > > Hervé Poussineau a écrit : > >IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). > > > >Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> > >--- > > target-ppc/translate_init.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > >diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > >index 6feb62a..248d3e0 100644 > >--- a/target-ppc/translate_init.c > >+++ b/target-ppc/translate_init.c > >@@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env) > > SPR_NOACCESS, SPR_NOACCESS, > > &spr_read_generic, &spr_write_generic, > > 0x00000000); > >- /* XXX : not implemented */ > >- spr_register(env, SPR_IABR, "IABR", > >- SPR_NOACCESS, SPR_NOACCESS, > >- &spr_read_generic, &spr_write_generic, > >- 0x00000000); > > /* Memory management */ > > gen_low_BATs(env); > > gen_6xx_7xx_soft_tlb(env, 64, 2); > >
mdroth a écrit : > On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote: >> Ping. >> This should be IMO committed to stable, as it fixes a crash with >> qemu-system-ppc -M prep -cpu 603e > > Ping^2. Looking to pull this in for 1.5.1 Ping^3 > >> Hervé >> >> Hervé Poussineau a écrit : >>> IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). >>> >>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> >>> --- >>> target-ppc/translate_init.c | 5 ----- >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c >>> index 6feb62a..248d3e0 100644 >>> --- a/target-ppc/translate_init.c >>> +++ b/target-ppc/translate_init.c >>> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env) >>> SPR_NOACCESS, SPR_NOACCESS, >>> &spr_read_generic, &spr_write_generic, >>> 0x00000000); >>> - /* XXX : not implemented */ >>> - spr_register(env, SPR_IABR, "IABR", >>> - SPR_NOACCESS, SPR_NOACCESS, >>> - &spr_read_generic, &spr_write_generic, >>> - 0x00000000); >>> /* Memory management */ >>> gen_low_BATs(env); >>> gen_6xx_7xx_soft_tlb(env, 64, 2); >> >
mdroth a écrit : > On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote: >> Ping. >> This should be IMO committed to stable, as it fixes a crash with >> qemu-system-ppc -M prep -cpu 603e > > Ping^2. Looking to pull this in for 1.5.1 Ping^3 >> Hervé Poussineau a écrit : >>> IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). >>> >>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> >>> --- >>> target-ppc/translate_init.c | 5 ----- >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c >>> index 6feb62a..248d3e0 100644 >>> --- a/target-ppc/translate_init.c >>> +++ b/target-ppc/translate_init.c >>> @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env) >>> SPR_NOACCESS, SPR_NOACCESS, >>> &spr_read_generic, &spr_write_generic, >>> 0x00000000); >>> - /* XXX : not implemented */ >>> - spr_register(env, SPR_IABR, "IABR", >>> - SPR_NOACCESS, SPR_NOACCESS, >>> - &spr_read_generic, &spr_write_generic, >>> - 0x00000000); >>> /* Memory management */ >>> gen_low_BATs(env); >>> gen_6xx_7xx_soft_tlb(env, 64, 2); >> >
Am 11.05.2013 21:03, schrieb Hervé Poussineau: > IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). > > Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> Confirmed, Reviewed-by: Andreas Färber <afaerber@suse.de> Andreas
On 11.05.2013, at 21:03, Hervé Poussineau wrote: > IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). > > Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> Thanks, applied to ppc-next. Sorry for the long delay - I was on vacation :) Alex > --- > target-ppc/translate_init.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 6feb62a..248d3e0 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env) > SPR_NOACCESS, SPR_NOACCESS, > &spr_read_generic, &spr_write_generic, > 0x00000000); > - /* XXX : not implemented */ > - spr_register(env, SPR_IABR, "IABR", > - SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > - 0x00000000); > /* Memory management */ > gen_low_BATs(env); > gen_6xx_7xx_soft_tlb(env, 64, 2); > -- > 1.7.10.4 >
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 6feb62a..248d3e0 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -4980,11 +4980,6 @@ static void init_proc_603E (CPUPPCState *env) SPR_NOACCESS, SPR_NOACCESS, &spr_read_generic, &spr_write_generic, 0x00000000); - /* XXX : not implemented */ - spr_register(env, SPR_IABR, "IABR", - SPR_NOACCESS, SPR_NOACCESS, - &spr_read_generic, &spr_write_generic, - 0x00000000); /* Memory management */ gen_low_BATs(env); gen_6xx_7xx_soft_tlb(env, 64, 2);
IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> --- target-ppc/translate_init.c | 5 ----- 1 file changed, 5 deletions(-)