| Message ID | 1368262741-24215-1-git-send-email-olivier.schonken@gmail.com |
|---|---|
| State | Accepted |
| Commit | e5ef6f7f71c0773af1f35b8a4e78669a8c3c8bf0 |
| Headers | show |
Dear Olivier Schonken, On Sat, 11 May 2013 10:59:01 +0200, Olivier Schonken wrote: > When using lttng-tools for userland tracing with lttng-libust lttng-modules is > not required, thus a dependency on building lttng-modules and a kernel is > overkill for lttng-tools. It also hides it from a user not wanting to build > a kernel. A comment has been added to lttng-modules to show a user that > lttng-modules is dependent on a kernel build. > > Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Peter, I believe this can go in 2013.05-rc. Thanks, Thomas
>>>>> "Olivier" == Olivier Schonken <olivier.schonken@gmail.com> writes:
Olivier> When using lttng-tools for userland tracing with lttng-libust
Olivier> lttng-modules is not required, thus a dependency on building
Olivier> lttng-modules and a kernel is overkill for lttng-tools. It
Olivier> also hides it from a user not wanting to build a kernel. A
Olivier> comment has been added to lttng-modules to show a user that
Olivier> lttng-modules is dependent on a kernel build.
Committed, thanks.
diff --git a/package/lttng-modules/Config.in b/package/lttng-modules/Config.in index 2a0f938..fb5947f 100644 --- a/package/lttng-modules/Config.in +++ b/package/lttng-modules/Config.in @@ -16,3 +16,6 @@ config BR2_PACKAGE_LTTNG_MODULES http://lttng.org/files/bundles/20111214/README.compatible.kernels.txt http://lttng.org + +comment "lttng-modules requires a linux kernel to be built" + depends on !BR2_LINUX_KERNEL diff --git a/package/lttng-tools/Config.in b/package/lttng-tools/Config.in index 3d95eeb..4f86e77 100644 --- a/package/lttng-tools/Config.in +++ b/package/lttng-tools/Config.in @@ -1,6 +1,5 @@ config BR2_PACKAGE_LTTNG_TOOLS bool "lttng-tools" - depends on BR2_PACKAGE_LTTNG_MODULES select BR2_PACKAGE_LIBURCU select BR2_PACKAGE_POPT # liburcu only works on some architectures and requires thread support
When using lttng-tools for userland tracing with lttng-libust lttng-modules is not required, thus a dependency on building lttng-modules and a kernel is overkill for lttng-tools. It also hides it from a user not wanting to build a kernel. A comment has been added to lttng-modules to show a user that lttng-modules is dependent on a kernel build. Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com> --- package/lttng-modules/Config.in | 3 +++ package/lttng-tools/Config.in | 1 - 2 files changed, 3 insertions(+), 1 deletion(-)