Patchwork 3c59x: shared interrupt problem

login
register
mail settings
Submitter Steffen Klassert
Date March 11, 2009, 11:31 a.m.
Message ID <20090311113130.GA26526@newton.mathematik.tu-chemnitz.de>
Download mbox | patch
Permalink /patch/24298/
State RFC
Delegated to: David Miller
Headers show

Comments

Steffen Klassert - March 11, 2009, 11:31 a.m.
On Tue, Mar 10, 2009 at 10:00:53AM +0100, Gerhard Pircher wrote:
> > 
> > This basically reverts a patch from akpm (bitkeeper cset 1.1046.95.8)
> > This patch was to workaround lots of "nobody cared" warnings generated
> > by boomerang_interrupt().
> > I added Andrew to the Cc, perhaps he can remember some details on this.
> I'm afraid this patch didn't fix the problem. I'm using scp to copy a big
> ISO file from my PC to the AmigaOne and the network transfer still stalls.
> I made a photo from the kernel oops printed out during shutdown.

Your photo shows exactly such a "nobody cared" warning that Andrew wanted 
to get rid of with his patch.

> BTW: shouldn't the driver use vortex_interrupt() to handle interrupts for
> a 3c920?
> 

It depends on the content of your NIC's eeprom which ISR the driver will use.
If your NIC is full bus master capable boomerang_interrupt() will be used,
if not vortex_interrupt() will be used. As far as I know the 3c920 is
of "tornado" type, so it should be full bus master capable.

Your first report showed dnComplete as a pending interrupt source.
Since the driver uses tx_interrupt_mitigation, this happens just if the 
tx ring is full. Could you please test the patch below? This disables
tx_interrupt_mitigation, so the dnComplete interrupt will be triggered 
with every packet.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index b2563d3..c45c400 100644
--- a/drivers/net/3c59x.c
+++ b/drivers/net/3c59x.c
@@ -60,7 +60,7 @@  static int watchdog = 5000;
  * of possible Tx stalls if the system is blocking interrupts
  * somewhere else.  Undefine this to disable.
  */
-#define tx_interrupt_mitigation 1
+#define tx_interrupt_mitigation 0
 
 /* Put out somewhat more debugging messages. (0: no msg, 1 minimal .. 6). */
 #define vortex_debug debug