Patchwork [RFC,01/42] drivers/ata: don't check resource with devm_ioremap_resource

login
register
mail settings
Submitter Wolfram Sang
Date May 10, 2013, 8:16 a.m.
Message ID <1368173847-5661-2-git-send-email-wsa@the-dreams.de>
Download mbox | patch
Permalink /patch/242930/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Wolfram Sang - May 10, 2013, 8:16 a.m.
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 drivers/ata/pata_ep93xx.c |    5 -----
 1 file changed, 5 deletions(-)

Patch

diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
index c1bfaf4..980b88e 100644
--- a/drivers/ata/pata_ep93xx.c
+++ b/drivers/ata/pata_ep93xx.c
@@ -933,11 +933,6 @@  static int ep93xx_pata_probe(struct platform_device *pdev)
 	}
 
 	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!mem_res) {
-		err = -ENXIO;
-		goto err_rel_gpio;
-	}
-
 	ide_base = devm_ioremap_resource(&pdev->dev, mem_res);
 	if (IS_ERR(ide_base)) {
 		err = PTR_ERR(ide_base);