Patchwork [1/4] Create package/freescale-imx directory With current version and download site

login
register
mail settings
Submitter H.Fijnvandraat@inter.nl.net
Date May 9, 2013, 5:41 p.m.
Message ID <1368121316-3645-2-git-send-email-h.fijnvandraat@inter.nl.net>
Download mbox | patch
Permalink /patch/242805/
State Superseded
Headers show

Comments

H.Fijnvandraat@inter.nl.net - May 9, 2013, 5:41 p.m.
Signed-off-by: Henk Fijnvandraat <h.fijnvandraat@inter.nl.net>
---
 package/freescale-imx/Config.in    |   16 ++++++++++++++++
 package/freescale-imx/freescale.mk |   13 +++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 package/freescale-imx/Config.in
 create mode 100644 package/freescale-imx/freescale.mk
Thomas Petazzoni - May 9, 2013, 9:55 p.m.
Dear Henk Fijnvandraat,

The first line of your commit log is too long. A commit log should look
like:

"""
A first line of less than ~80 characters to summarize the commit

Some more paragraphs here to explain what you're doing. The important
thing is that there is an empty new line between the summary line, and
the following paragraphs.

And some more details.

Signed-off-by: Someone <foo@bar.com>
"""

On Thu,  9 May 2013 19:41:53 +0200, Henk Fijnvandraat wrote:

> diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> new file mode 100644
> index 0000000..8d0e347
> --- /dev/null
> +++ b/package/freescale-imx/Config.in
> @@ -0,0 +1,16 @@
> +comment "freescale-imx is only relevant for the i.MXxx series from Freescale"
> +	depends on BR2_arm
> +
> +menuconfig BR2_PACKAGE_IMX
> +	bool "freescale-imx"
> +	depends on BR2_arm
> +	help
> +	  This option enables the selection of some packages specific for
> +	  the i.MXxx series of processors from Freescale.
> +	  freescale-imx needs an imx-specific kernel to be built
> +
> +
> +if BR2_PACKAGE_IMX
> +source "package/freescale-imx/imx-lib/Config.in"
> +source "package/freescale-imx/firmware-imx/Config.in"
> +endif

This doesn't work: you're moving the packages only in PATCH 2/4.

We try to make patches bisectable: i.e, the code should work at any
point in the patch series. Imagine what happens if your PATCH 1/4 gets
applied and not the following ones.

Suggestion:

 * PATCH 1 adds freescale-imx/Config.in and freescale-imx/freescale.mk,
   but the Config.in doesn't source the imx-lib/Config and
   firmware-imx/Config.in.

 * PATCH 2 moves the imx-lib package into package/freescale-imx/

 * PATCH 3 moves the firmware-imx package into package/freescale-imx/

Thanks!

Thomas

Patch

diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
new file mode 100644
index 0000000..8d0e347
--- /dev/null
+++ b/package/freescale-imx/Config.in
@@ -0,0 +1,16 @@ 
+comment "freescale-imx is only relevant for the i.MXxx series from Freescale"
+	depends on BR2_arm
+
+menuconfig BR2_PACKAGE_IMX
+	bool "freescale-imx"
+	depends on BR2_arm
+	help
+	  This option enables the selection of some packages specific for
+	  the i.MXxx series of processors from Freescale.
+	  freescale-imx needs an imx-specific kernel to be built
+
+
+if BR2_PACKAGE_IMX
+source "package/freescale-imx/imx-lib/Config.in"
+source "package/freescale-imx/firmware-imx/Config.in"
+endif
diff --git a/package/freescale-imx/freescale.mk b/package/freescale-imx/freescale.mk
new file mode 100644
index 0000000..945c51c
--- /dev/null
+++ b/package/freescale-imx/freescale.mk
@@ -0,0 +1,13 @@ 
+#############################################################
+#
+# freescale-imx
+#
+#############################################################
+
+IMX_VERSION_LEVEL = 1.1.0
+
+# No official download site from freescale, just this mirror
+IMX_MIRROR_SITE   = http://download.ossystems.com.br/bsp/freescale/source
+
+include package/freescale-imx/*/*.mk
+