Patchwork socketcand: add license information

login
register
mail settings
Submitter gilles.talis@gmail.com
Date May 9, 2013, 5:30 p.m.
Message ID <1368120627-26385-1-git-send-email-gilles.talis@gmail.com>
Download mbox | patch
Permalink /patch/242799/
State Rejected
Headers show

Comments

gilles.talis@gmail.com - May 9, 2013, 5:30 p.m.
Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/socketcand/socketcand.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Thomas Petazzoni - May 9, 2013, 5:40 p.m.
Dear Gilles Talis,

On Thu,  9 May 2013 10:30:27 -0700, Gilles Talis wrote:

> +SOCKETCAND_LICENSE = GPLv2

Are you sure? The only licensing information I can find is in
socketcand.c, and it says:

 * Authors:
 * Andre Naujoks (the socket server stuff)
 * Oliver Hartkopp (the rest)
 * Jan-Niklas Meier (extensions for use with kayak)
 *
 * Copyright (c) 2002-2009 Volkswagen Group Electronic Research
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the
 *    documentation and/or other materials provided with the distribution.
 * 3. Neither the name of Volkswagen nor the names of its contributors
 *    may be used to endorse or promote products derived from this software
 *    without specific prior written permission.
 *
 * Alternatively, provided that this notice is retained in full, this
 * software may be distributed under the terms of the GNU General
 * Public License ("GPL") version 2, in which case the provisions of the
 * GPL apply INSTEAD OF those given above.
 *
 * The provided data structures and external interfaces from this code
 * are not restricted to be used by modules with a GPL compatible license.

So the license is either GPLv2 or BSD-3c.

Thomas
gilles.talis@gmail.com - May 9, 2013, 5:48 p.m.
Dear Thomas Petazzoni,

No, I am not sure. And I agree with you, the license information for this
package is scarce and confusing. Arch-linux distribution tagged it as GPLv2
[1], and the package maintainer did not seem to disagree. This is why I
went with GPLv2. Would you prefer we did not add license information at all?

Thanks
Gilles

[1] https://aur.archlinux.org/packages/socketcand-git/


2013/5/9 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

> Dear Gilles Talis,
>
> On Thu,  9 May 2013 10:30:27 -0700, Gilles Talis wrote:
>
> > +SOCKETCAND_LICENSE = GPLv2
>
> Are you sure? The only licensing information I can find is in
> socketcand.c, and it says:
>
>  * Authors:
>  * Andre Naujoks (the socket server stuff)
>  * Oliver Hartkopp (the rest)
>  * Jan-Niklas Meier (extensions for use with kayak)
>  *
>  * Copyright (c) 2002-2009 Volkswagen Group Electronic Research
>  * All rights reserved.
>  *
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>  * are met:
>  * 1. Redistributions of source code must retain the above copyright
>  *    notice, this list of conditions and the following disclaimer.
>  * 2. Redistributions in binary form must reproduce the above copyright
>  *    notice, this list of conditions and the following disclaimer in the
>  *    documentation and/or other materials provided with the distribution.
>  * 3. Neither the name of Volkswagen nor the names of its contributors
>  *    may be used to endorse or promote products derived from this software
>  *    without specific prior written permission.
>  *
>  * Alternatively, provided that this notice is retained in full, this
>  * software may be distributed under the terms of the GNU General
>  * Public License ("GPL") version 2, in which case the provisions of the
>  * GPL apply INSTEAD OF those given above.
>  *
>  * The provided data structures and external interfaces from this code
>  * are not restricted to be used by modules with a GPL compatible license.
>
> So the license is either GPLv2 or BSD-3c.
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
gilles.talis@gmail.com - May 9, 2013, 5:55 p.m.
Dear Thomas Petazzoni and all,

2013/5/9 Gilles Talis <gilles.talis@gmail.com>
>
> Dear Thomas Petazzoni,
>
> No, I am not sure. And I agree with you, the license information for this package is scarce and confusing. Arch-linux distribution tagged it as GPLv2 [1], and the package maintainer did not seem to disagree. This is why I went with GPLv2. Would you prefer we did not add license information at all?
>
> Thanks
> Gilles
>
> [1] https://aur.archlinux.org/packages/socketcand-git/
>
>
> 2013/5/9 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>
>> Dear Gilles Talis,
>>
>> On Thu,  9 May 2013 10:30:27 -0700, Gilles Talis wrote:
>>
>> > +SOCKETCAND_LICENSE = GPLv2
>>
>> Are you sure? The only licensing information I can find is in
>> socketcand.c, and it says:
>>
>>  * Authors:
>>  * Andre Naujoks (the socket server stuff)
>>  * Oliver Hartkopp (the rest)
>>  * Jan-Niklas Meier (extensions for use with kayak)
>>  *
>>  * Copyright (c) 2002-2009 Volkswagen Group Electronic Research
>>  * All rights reserved.
>>  *
>>  * Redistribution and use in source and binary forms, with or without
>>  * modification, are permitted provided that the following conditions
>>  * are met:
>>  * 1. Redistributions of source code must retain the above copyright
>>  *    notice, this list of conditions and the following disclaimer.
>>  * 2. Redistributions in binary form must reproduce the above copyright
>>  *    notice, this list of conditions and the following disclaimer in the
>>  *    documentation and/or other materials provided with the distribution.
>>  * 3. Neither the name of Volkswagen nor the names of its contributors
>>  *    may be used to endorse or promote products derived from this software
>>  *    without specific prior written permission.
>>  *
>>  * Alternatively, provided that this notice is retained in full, this
>>  * software may be distributed under the terms of the GNU General
>>  * Public License ("GPL") version 2, in which case the provisions of the
>>  * GPL apply INSTEAD OF those given above.
>>  *
>>  * The provided data structures and external interfaces from this code
>>  * are not restricted to be used by modules with a GPL compatible license.
>>
>> So the license is either GPLv2 or BSD-3c.
>>
>> Thomas
>> --
>> Thomas Petazzoni, Free Electrons
>> Kernel, drivers, real-time and embedded Linux
>> development, consulting, training and support.
>> http://free-electrons.com

All apologies for top-posting and HTML format. My gmail parameters
changed against my will :-(. I am fixing it now.
Hope this is better :-)

Gilles.
>
>

Patch

diff --git a/package/socketcand/socketcand.mk b/package/socketcand/socketcand.mk
index efade31..0826579 100644
--- a/package/socketcand/socketcand.mk
+++ b/package/socketcand/socketcand.mk
@@ -7,5 +7,6 @@  SOCKETCAND_VERSION = 7d06986
 SOCKETCAND_SITE = http://github.com/dschanoeh/socketcand/tarball/master
 SOCKETCAND_AUTORECONF = YES
 SOCKETCAND_DEPENDENCIES = libconfig
+SOCKETCAND_LICENSE = GPLv2
 
 $(eval $(autotools-package))