Patchwork [20/21] powerpc/ps3: remove inline marking of EXPORT_SYMBOL functions

login
register
mail settings
Submitter Denis Efremov
Date May 9, 2013, 10:36 a.m.
Message ID <1368095819-11011-9-git-send-email-yefremov.denis@gmail.com>
Download mbox | patch
Permalink /patch/242756/
State Accepted
Commit e9419669faacf90e7a4e648d38f61c067a47c0ff
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Denis Efremov - May 9, 2013, 10:36 a.m.
EXPORT_SYMBOL and inline directives are contradictory to each other.
The patch fixes this inconsistency.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
 arch/powerpc/platforms/ps3/spu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Geoff Levand - May 9, 2013, 11:35 a.m.
On Thu, 2013-05-09 at 14:36 +0400, Denis Efremov wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
> ---
>  arch/powerpc/platforms/ps3/spu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks good, thanks.

Acked-by: Geoff Levand <geoff@infradead.org>
Geert Uytterhoeven - May 17, 2013, 4:05 p.m.
On Thu, May 9, 2013 at 12:36 PM, Denis Efremov <yefremov.denis@gmail.com> wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
> ---
>  arch/powerpc/platforms/ps3/spu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
> index e17fa14..a0bca05 100644
> --- a/arch/powerpc/platforms/ps3/spu.c
> +++ b/arch/powerpc/platforms/ps3/spu.c
> @@ -143,7 +143,7 @@ static void _dump_areas(unsigned int spe_id, unsigned long priv2,
>         pr_debug("%s:%d: shadow:  %lxh\n", func, line, shadow);
>  }
>
> -inline u64 ps3_get_spe_id(void *arg)
> +u64 ps3_get_spe_id(void *arg)
>  {
>         return spu_pdata(arg)->spe_id;
>  }

FYI, this symbol is not used in mainline.

IIRC, it's used for profiling only. Any chance the profile code will
ever make it
in mainline?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Geoff Levand - May 28, 2013, 11:14 p.m.
Hi Geert,

On Fri, 2013-05-17 at 18:05 +0200, Geert Uytterhoeven wrote:
> On Thu, May 9, 2013 at 12:36 PM, Denis Efremov <yefremov.denis@gmail.com> wrote:
> > -inline u64 ps3_get_spe_id(void *arg)
> > +u64 ps3_get_spe_id(void *arg)
> >  {
> >         return spu_pdata(arg)->spe_id;
> >  }
> 
> FYI, this symbol is not used in mainline.
> 
> IIRC, it's used for profiling only. Any chance the profile code will
> ever make it
> in mainline?

As I announced (below), I dropped the profiling patches since
ps3-queue-v3.8.

The profiling code does not use ps3_get_spe_id(), so I think we should
remove it.  I'll submit a patch.

-Geoff

-------- Forwarded Message --------
From: Geoff Levand <geoff@infradead.org>
To: cbe-oss-dev@lists.ozlabs.org
Subject: Dropping PS3 oprofile support in v3.8
Date: Wed, 13 Feb 2013 17:30:39 -0800

Hi All,

I'll be dropping the PS3 oprofile patches from my ps3-linux git tree
from linux-3.8.  These are the patches: 

 7f02610 ps3-debugging: Add oprofile test script
 49213b6 powerpc/ps3: PS3 oprofile support
 aee2985 powerpc/ps3: Add ps3 pmu platform routines
 531c3f4 powerpc/ps3: Rearrange order of lpm routines
 9d8a7d3 powerpc/cell: Add pmu platform abstraction
 6865b99 powerpc/cell: Rearrange order of pmu routines

These patches will still be available in the ps3-queue-v3.7 and earlier
branches for anyone who wants them.

-Geoff

Patch

diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
index e17fa14..a0bca05 100644
--- a/arch/powerpc/platforms/ps3/spu.c
+++ b/arch/powerpc/platforms/ps3/spu.c
@@ -143,7 +143,7 @@  static void _dump_areas(unsigned int spe_id, unsigned long priv2,
 	pr_debug("%s:%d: shadow:  %lxh\n", func, line, shadow);
 }
 
-inline u64 ps3_get_spe_id(void *arg)
+u64 ps3_get_spe_id(void *arg)
 {
 	return spu_pdata(arg)->spe_id;
 }