Patchwork [PATCHv2] net: smsc911x: don't artificially limit build

login
register
mail settings
Submitter Mark Rutland
Date May 9, 2013, 10:23 a.m.
Message ID <1368095027-8448-1-git-send-email-mark.rutland@arm.com>
Download mbox | patch
Permalink /patch/242749/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Mark Rutland - May 9, 2013, 10:23 a.m.
Currently the SMSC911X driver may only be built for a specific set of
architectures, being limited to do so by a Kconfig depends line. This
means that if a platform wishes to use the driver, its architecture must
be added to the list explicitly, introducing pointless churn.

This may have been due to the driver's use of the {read,write}s{b,w,l}
functions, which have since been replaced with the more standard
io{read,write}{8,16,32}_rep. We can instead depend on HAS_IOMEM, which
should prevent build issues while allowing the driver to be built for
currently unlisted architectures, including x86 and arm64.

This patch removes the explicit list of architectures from the driver's
depend line, and replaces it with a dependency on HAS_IOMEM.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/smsc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Mark Rutland - May 9, 2013, 10:26 a.m.
This should of course be PATCH, not PATCHv2.

I blame my shell's command history completion.

Mark.

On Thu, May 09, 2013 at 11:23:47AM +0100, Mark Rutland wrote:
> Currently the SMSC911X driver may only be built for a specific set of
> architectures, being limited to do so by a Kconfig depends line. This
> means that if a platform wishes to use the driver, its architecture must
> be added to the list explicitly, introducing pointless churn.
> 
> This may have been due to the driver's use of the {read,write}s{b,w,l}
> functions, which have since been replaced with the more standard
> io{read,write}{8,16,32}_rep. We can instead depend on HAS_IOMEM, which
> should prevent build issues while allowing the driver to be built for
> currently unlisted architectures, including x86 and arm64.
> 
> This patch removes the explicit list of architectures from the driver's
> depend line, and replaces it with a dependency on HAS_IOMEM.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/smsc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig
> index bb4c167..ff9e994 100644
> --- a/drivers/net/ethernet/smsc/Kconfig
> +++ b/drivers/net/ethernet/smsc/Kconfig
> @@ -97,7 +97,7 @@ config SMC911X
>  
>  config SMSC911X
>  	tristate "SMSC LAN911x/LAN921x families embedded ethernet support"
> -	depends on (ARM || SUPERH || BLACKFIN || MIPS || MN10300)
> +	depends on HAS_IOMEM
>  	select CRC32
>  	select NET_CORE
>  	select MII
> -- 
> 1.8.1.1
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - May 9, 2013, 9:04 p.m.
From: Mark Rutland <mark.rutland@arm.com>
Date: Thu, 9 May 2013 11:26:50 +0100

> This should of course be PATCH, not PATCHv2.
> 
> I blame my shell's command history completion.

That's the least of your problems.

Every single list posting bounces when it is sent to your address,
with error "550 Envelope blocked - User Entry - http://www.mimecast.com/knowledgebase/KBID10473.htm#550"

I've unsubscribed you and I'm ignoring your patch submissions until
your email is actually working properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig
index bb4c167..ff9e994 100644
--- a/drivers/net/ethernet/smsc/Kconfig
+++ b/drivers/net/ethernet/smsc/Kconfig
@@ -97,7 +97,7 @@  config SMC911X
 
 config SMSC911X
 	tristate "SMSC LAN911x/LAN921x families embedded ethernet support"
-	depends on (ARM || SUPERH || BLACKFIN || MIPS || MN10300)
+	depends on HAS_IOMEM
 	select CRC32
 	select NET_CORE
 	select MII