Message ID | 20090311020024.22904.48769.stgit@lost.foo-projects.org |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Tue, Mar 10, 2009 at 7:00 PM, Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote: > From: Chris Leech <christopher.leech@intel.com> > > Multiple unicast address support appears to have been broken with the > change to support net_device_ops. This a regression from 2.6.28 to 2.6.29. > > I'm not 100% on whether ndo_set_multicast_list can be NULL after this > or not. If ndo_set_rx_mode is set everything _should_ be using it. > > Signed-off-by: Chris Leech <christopher.leech@intel.com> > Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > --- > > drivers/net/ixgbe/ixgbe_main.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c > index d0b9870..8e7a51b 100644 > --- a/drivers/net/ixgbe/ixgbe_main.c > +++ b/drivers/net/ixgbe/ixgbe_main.c > @@ -4341,6 +4341,7 @@ static const struct net_device_ops ixgbe_netdev_ops = { > .ndo_stop = ixgbe_close, > .ndo_start_xmit = ixgbe_xmit_frame, > .ndo_get_stats = ixgbe_get_stats, > + .ndo_set_rx_mode = ixgbe_set_rx_mode, > .ndo_set_multicast_list = ixgbe_set_rx_mode, > .ndo_validate_addr = eth_validate_addr, > .ndo_set_mac_address = ixgbe_set_mac, > > -- Dave, I know that it is very late in the rc cycle, so I understand if this change cannot make it into 2.6.29. If it is possible, we would like to see this 1 line change make 2.6.29.
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Date: Tue, 10 Mar 2009 20:35:28 -0700 > On Tue, Mar 10, 2009 at 7:00 PM, Jeff Kirsher > <jeffrey.t.kirsher@intel.com> wrote: > > From: Chris Leech <christopher.leech@intel.com> > > > > Multiple unicast address support appears to have been broken with the > > change to support net_device_ops. This a regression from 2.6.28 to 2.6.29. > > > > I'm not 100% on whether ndo_set_multicast_list can be NULL after this > > or not. If ndo_set_rx_mode is set everything _should_ be using it. > > > > Signed-off-by: Chris Leech <christopher.leech@intel.com> > > Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> .. > I know that it is very late in the rc cycle, so I understand if > this change cannot make it into 2.6.29. If it is possible, we would > like to see this 1 line change make 2.6.29. Ok, since you asked nicely :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index d0b9870..8e7a51b 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -4341,6 +4341,7 @@ static const struct net_device_ops ixgbe_netdev_ops = { .ndo_stop = ixgbe_close, .ndo_start_xmit = ixgbe_xmit_frame, .ndo_get_stats = ixgbe_get_stats, + .ndo_set_rx_mode = ixgbe_set_rx_mode, .ndo_set_multicast_list = ixgbe_set_rx_mode, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = ixgbe_set_mac,