From patchwork Thu May 9 08:27:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Libo Chen X-Patchwork-Id: 242724 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8AE7C2C00F2 for ; Thu, 9 May 2013 18:28:44 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752587Ab3EII2U (ORCPT ); Thu, 9 May 2013 04:28:20 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:26546 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375Ab3EII2R (ORCPT ); Thu, 9 May 2013 04:28:17 -0400 Received: from 172.24.2.119 (EHLO szxeml210-edg.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.4-GA FastPath queued) with ESMTP id BBI07290; Thu, 09 May 2013 16:27:59 +0800 (CST) Received: from SZXEML403-HUB.china.huawei.com (10.82.67.35) by szxeml210-edg.china.huawei.com (172.24.2.183) with Microsoft SMTP Server (TLS) id 14.1.323.7; Thu, 9 May 2013 16:27:32 +0800 Received: from localhost (10.135.72.158) by szxeml403-hub.china.huawei.com (10.82.67.35) with Microsoft SMTP Server id 14.1.323.7; Thu, 9 May 2013 16:27:24 +0800 From: Libo Chen To: , CC: , , , , Libo Chen Subject: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful Date: Thu, 9 May 2013 16:27:23 +0800 Message-ID: <1368088044-20408-2-git-send-email-libo.chen@huawei.com> X-Mailer: git-send-email 1.8.1.msysgit.1 In-Reply-To: <1368088044-20408-1-git-send-email-libo.chen@huawei.com> References: <1368088044-20408-1-git-send-email-libo.chen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.135.72.158] X-CFilter-Loop: Reflected Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org down out_error_no_irq. When platform_get_irq fail, no need to free peripheral Signed-off-by: Libo Chen Acked-by: Sonic Zhang --- drivers/i2c/busses/i2c-bfin-twi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c index 05080c4..6617645 100644 --- a/drivers/i2c/busses/i2c-bfin-twi.c +++ b/drivers/i2c/busses/i2c-bfin-twi.c @@ -709,9 +709,9 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev) out_error_add_adapter: free_irq(iface->irq, iface); out_error_req_irq: -out_error_no_irq: peripheral_free_list((unsigned short *)pdev->dev.platform_data); out_error_pin_mux: +out_error_no_irq: iounmap(iface->regs_base); out_error_ioremap: out_error_get_res: