Patchwork [1/2] clean unnecessary code: don't check g_strdup arg for NULL

login
register
mail settings
Submitter Robert Wang
Date May 9, 2013, 7:53 a.m.
Message ID <1368086030-3847-1-git-send-email-wdongxu@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/242715/
State New
Headers show

Comments

Robert Wang - May 9, 2013, 7:53 a.m.
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
---
 util/uri.c | 2 +-
 vl.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Michael Tokarev - May 9, 2013, 8:23 a.m.
09.05.2013 11:53, Dong Xu Wang wrote:
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>

Thank you Dong, (re)applied both patches to the trivial patch queue.

/mjt

Patch

diff --git a/util/uri.c b/util/uri.c
index 4238729..e348c17 100644
--- a/util/uri.c
+++ b/util/uri.c
@@ -2162,7 +2162,7 @@  query_params_append (struct QueryParams *ps,
     }
 
     ps->p[ps->n].name = g_strdup(name);
-    ps->p[ps->n].value = value ? g_strdup(value) : NULL;
+    ps->p[ps->n].value = g_strdup(value);
     ps->p[ps->n].ignore = 0;
     ps->n++;
 
diff --git a/vl.c b/vl.c
index 6e6225f..be0a93c 100644
--- a/vl.c
+++ b/vl.c
@@ -1215,7 +1215,7 @@  void add_boot_device_path(int32_t bootindex, DeviceState *dev,
 
     node = g_malloc0(sizeof(FWBootEntry));
     node->bootindex = bootindex;
-    node->suffix = suffix ? g_strdup(suffix) : NULL;
+    node->suffix = g_strdup(suffix);
     node->dev = dev;
 
     QTAILQ_FOREACH(i, &fw_boot_order, link) {