From patchwork Wed May 8 23:33:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 242669 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BE6432C00F0 for ; Thu, 9 May 2013 09:36:33 +1000 (EST) Received: from localhost ([::1]:46888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaDuR-0007ez-9y for incoming@patchwork.ozlabs.org; Wed, 08 May 2013 19:36:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaDtf-0007eE-0b for qemu-devel@nongnu.org; Wed, 08 May 2013 19:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaDtd-00070R-RC for qemu-devel@nongnu.org; Wed, 08 May 2013 19:35:42 -0400 Received: from mail-ie0-x22e.google.com ([2607:f8b0:4001:c03::22e]:34987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaDtd-00070M-Md for qemu-devel@nongnu.org; Wed, 08 May 2013 19:35:41 -0400 Received: by mail-ie0-f174.google.com with SMTP id 10so4379126ied.33 for ; Wed, 08 May 2013 16:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=lNdbydtYe2uETPSlEJh7u7QlpUJmnGnMpryKiKq4yT8=; b=0I5LStnubTHv+uA6W+sC3Gl8zX2JNcNNJj3Kl2w1ykMj4PpPxTj+VsDISss3E9JmOM Jt+dzDDlRrZReqLQpmuumvS9DDcWmgURc1rhydIsPnXjUOULAfgCJlKsMOrCf7BwuDKQ MO7TOXR+eqGnF+GeksI2C5jt5pYZ0NGZFJDncJ5tZQuR6lmWcGq3hyAldN5XzESficxo vTfsr58n6Fo2CHsEtpDi4yK3UGE9rECbhfyLoD7iM9f/V9LXrHJ1Pdf06ytaeWuCucWi nFJ45gLzX34yEAprluZJoRBMYL+LaE4LQHzP0i1ifUs9hcEwn0ZY/zCgVtXi98YWiq3h RwtQ== X-Received: by 10.50.17.71 with SMTP id m7mr3524514igd.5.1368056141223; Wed, 08 May 2013 16:35:41 -0700 (PDT) Received: from localhost (cpe-72-177-121-217.austin.res.rr.com. [72.177.121.217]) by mx.google.com with ESMTPSA id c2sm3835800igv.1.2013.05.08.16.35.40 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 08 May 2013 16:35:40 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Wed, 8 May 2013 18:33:51 -0500 Message-Id: <1368056037-16350-3-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1368056037-16350-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1368056037-16350-1-git-send-email-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::22e Cc: akong@redhat.com, lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH 2/8] qapi: qapi-visit.py, fix list handling for union types X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Currently we assume non-list types when generating visitor routines for union types. This is broken, since values like ['Type'] need to mapped to 'TypeList'. We already have a type_name() function to handle this that we use for generating struct visitors, so use that here as well. Signed-off-by: Michael Roth --- scripts/qapi-visit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index a276540..4c4de4b 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -174,7 +174,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error ** ''', abbrev = de_camel_case(name).upper(), enum = c_fun(de_camel_case(key),False).upper(), - c_type=members[key], + c_type=type_name(members[key]), c_name=c_fun(key)) ret += mcgen('''