diff mbox

Remove OSS support for OpenBSD

Message ID 20130508113924.GA7698@rox.home.comstyle.com
State New
Headers show

Commit Message

Brad Smith May 8, 2013, 11:39 a.m. UTC
Remove the OSS support for OpenBSD. The OSS API has not been usable
for quite some time.

Signed-off-by: Brad Smith <brad@comstyle.com>

Comments

Brad Smith May 24, 2013, 10:16 p.m. UTC | #1
On Wed, May 08, 2013 at 07:39:25AM -0400, Brad Smith wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>

ping.

> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
>  #include <sys/mman.h>
>  #include <sys/types.h>
>  #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
>  #include <sys/soundcard.h>
> -#endif
>  #include "qemu-common.h"
>  #include "qemu/main-loop.h"
>  #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 9439f1c..89dda5b 100755
> --- a/configure
> +++ b/configure
> @@ -468,8 +468,7 @@ OpenBSD)
>    bsd="yes"
>    make="${MAKE-gmake}"
>    audio_drv_list="oss"
> -  audio_possible_drivers="oss sdl esd"
> -  oss_lib="-lossaudio"
> +  audio_possible_drivers="sdl esd"
>  ;;
>  Darwin)
>    bsd="yes"
Laszlo Ersek May 24, 2013, 10:51 p.m. UTC | #2
On 05/08/13 13:39, Brad Smith wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>
> 
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
>  #include <sys/mman.h>
>  #include <sys/types.h>
>  #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
>  #include <sys/soundcard.h>
> -#endif
>  #include "qemu-common.h"
>  #include "qemu/main-loop.h"
>  #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 9439f1c..89dda5b 100755
> --- a/configure
> +++ b/configure
> @@ -468,8 +468,7 @@ OpenBSD)
>    bsd="yes"
>    make="${MAKE-gmake}"
>    audio_drv_list="oss"
> -  audio_possible_drivers="oss sdl esd"
> -  oss_lib="-lossaudio"
> +  audio_possible_drivers="sdl esd"
>  ;;
>  Darwin)
>    bsd="yes"
> 

Shouldn't the default audio driver list ($audio_drv_list) be a subset of
the possible driver list?

Thanks,
Laszlo
Brad Smith May 24, 2013, 11:01 p.m. UTC | #3
On Sat, May 25, 2013 at 12:51:23AM +0200, Laszlo Ersek wrote:
> On 05/08/13 13:39, Brad Smith wrote:
> > Remove the OSS support for OpenBSD. The OSS API has not been usable
> > for quite some time.
> > 
> > Signed-off-by: Brad Smith <brad@comstyle.com>
> > 
> > diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> > index 00be9c9..007c641 100644
> > --- a/audio/ossaudio.c
> > +++ b/audio/ossaudio.c
> > @@ -25,11 +25,7 @@
> >  #include <sys/mman.h>
> >  #include <sys/types.h>
> >  #include <sys/ioctl.h>
> > -#ifdef __OpenBSD__
> > -#include <soundcard.h>
> > -#else
> >  #include <sys/soundcard.h>
> > -#endif
> >  #include "qemu-common.h"
> >  #include "qemu/main-loop.h"
> >  #include "qemu/host-utils.h"
> > diff --git a/configure b/configure
> > index 9439f1c..89dda5b 100755
> > --- a/configure
> > +++ b/configure
> > @@ -468,8 +468,7 @@ OpenBSD)
> >    bsd="yes"
> >    make="${MAKE-gmake}"
> >    audio_drv_list="oss"
> > -  audio_possible_drivers="oss sdl esd"
> > -  oss_lib="-lossaudio"
> > +  audio_possible_drivers="sdl esd"
> >  ;;
> >  Darwin)
> >    bsd="yes"
> > 
> 
> Shouldn't the default audio driver list ($audio_drv_list) be a subset of
> the possible driver list?

My mistake. A new patch sent.
diff mbox

Patch

diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 00be9c9..007c641 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@ -25,11 +25,7 @@ 
 #include <sys/mman.h>
 #include <sys/types.h>
 #include <sys/ioctl.h>
-#ifdef __OpenBSD__
-#include <soundcard.h>
-#else
 #include <sys/soundcard.h>
-#endif
 #include "qemu-common.h"
 #include "qemu/main-loop.h"
 #include "qemu/host-utils.h"
diff --git a/configure b/configure
index 9439f1c..89dda5b 100755
--- a/configure
+++ b/configure
@@ -468,8 +468,7 @@  OpenBSD)
   bsd="yes"
   make="${MAKE-gmake}"
   audio_drv_list="oss"
-  audio_possible_drivers="oss sdl esd"
-  oss_lib="-lossaudio"
+  audio_possible_drivers="sdl esd"
 ;;
 Darwin)
   bsd="yes"