Patchwork acpica: Fix for _INI regression.

login
register
mail settings
Submitter Colin King
Date May 8, 2013, 7:03 a.m.
Message ID <1367996594-15061-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/242509/
State Accepted
Headers show

Comments

Colin King - May 8, 2013, 7:03 a.m.
From: Colin Ian King <colin.king@canonical.com>

This change fixes a problem introduced in 20130328 where _INI methods are no
longer executed properly because of a memory block that is not initialized
properly.
ACPICA BZ 1016. Tomasz Nowicki <tomasz.nowicki@linaro.org>.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpica/source/components/namespace/nsinit.c | 1 +
 1 file changed, 1 insertion(+)
Alex Hung - May 10, 2013, 12:45 a.m.
On 05/08/2013 03:03 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This change fixes a problem introduced in 20130328 where _INI methods are no
> longer executed properly because of a memory block that is not initialized
> properly.
> ACPICA BZ 1016. Tomasz Nowicki <tomasz.nowicki@linaro.org>.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpica/source/components/namespace/nsinit.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/acpica/source/components/namespace/nsinit.c b/src/acpica/source/components/namespace/nsinit.c
> index e6b9d43..e0fafda 100644
> --- a/src/acpica/source/components/namespace/nsinit.c
> +++ b/src/acpica/source/components/namespace/nsinit.c
> @@ -681,6 +681,7 @@ AcpiNsInitOneDevice (
>       ACPI_DEBUG_EXEC (AcpiUtDisplayInitPathname (
>           ACPI_TYPE_METHOD, DeviceNode, METHOD_NAME__INI));
>
> +    ACPI_MEMSET (Info, 0, sizeof (ACPI_EVALUATE_INFO));
>       Info->PrefixNode = DeviceNode;
>       Info->RelativePathname = METHOD_NAME__INI;
>       Info->Parameters = NULL;
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - May 20, 2013, 7:55 a.m.
On Wed, May 8, 2013 at 3:03 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This change fixes a problem introduced in 20130328 where _INI methods are no
> longer executed properly because of a memory block that is not initialized
> properly.
> ACPICA BZ 1016. Tomasz Nowicki <tomasz.nowicki@linaro.org>.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpica/source/components/namespace/nsinit.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/acpica/source/components/namespace/nsinit.c b/src/acpica/source/components/namespace/nsinit.c
> index e6b9d43..e0fafda 100644
> --- a/src/acpica/source/components/namespace/nsinit.c
> +++ b/src/acpica/source/components/namespace/nsinit.c
> @@ -681,6 +681,7 @@ AcpiNsInitOneDevice (
>      ACPI_DEBUG_EXEC (AcpiUtDisplayInitPathname (
>          ACPI_TYPE_METHOD, DeviceNode, METHOD_NAME__INI));
>
> +    ACPI_MEMSET (Info, 0, sizeof (ACPI_EVALUATE_INFO));
>      Info->PrefixNode = DeviceNode;
>      Info->RelativePathname = METHOD_NAME__INI;
>      Info->Parameters = NULL;
> --
> 1.8.1.2
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/acpica/source/components/namespace/nsinit.c b/src/acpica/source/components/namespace/nsinit.c
index e6b9d43..e0fafda 100644
--- a/src/acpica/source/components/namespace/nsinit.c
+++ b/src/acpica/source/components/namespace/nsinit.c
@@ -681,6 +681,7 @@  AcpiNsInitOneDevice (
     ACPI_DEBUG_EXEC (AcpiUtDisplayInitPathname (
         ACPI_TYPE_METHOD, DeviceNode, METHOD_NAME__INI));
 
+    ACPI_MEMSET (Info, 0, sizeof (ACPI_EVALUATE_INFO));
     Info->PrefixNode = DeviceNode;
     Info->RelativePathname = METHOD_NAME__INI;
     Info->Parameters = NULL;