From patchwork Tue May 7 22:17:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinghai Lu X-Patchwork-Id: 242474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EC13A2C011A for ; Wed, 8 May 2013 08:18:58 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750772Ab3EGWSI (ORCPT ); Tue, 7 May 2013 18:18:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21166 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650Ab3EGWSF (ORCPT ); Tue, 7 May 2013 18:18:05 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r47MHtI6029473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 May 2013 22:17:56 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r47MHtOD015803 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 7 May 2013 22:17:56 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r47MHsrw014159; Tue, 7 May 2013 22:17:54 GMT Received: from linux-siqj.site (/10.132.126.191) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 07 May 2013 15:17:54 -0700 From: Yinghai Lu To: Bjorn Helgaas , Benjamin Herrenschmidt , Gavin Shan Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yinghai Lu Subject: [PATCH v3 3/5] PCI: Skip IORESOURCE_MMIO allocation for root bus without MMIO range Date: Tue, 7 May 2013 15:17:32 -0700 Message-Id: <1367965054-9013-4-git-send-email-yinghai@kernel.org> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1367965054-9013-1-git-send-email-yinghai@kernel.org> References: <1367965054-9013-1-git-send-email-yinghai@kernel.org> X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org For x86 8 sockets or 32 sockets system that will have one root bus per socket, They may have some root buses do not have mmio non-pref range. We should not fall into retry in this case, as root bus does not mmio non-pref range. We check if the root bus has mmio-nonpref range, and set bus_res_type_mask, and pass it to assign_resources and don't add mmio-nonpref res to failed list for root bus that does not have mmio-nonpref range. So even BIOS set wrong value to pci devices and bridges will still get cleared. Signed-off-by: Yinghai Lu --- drivers/pci/setup-bus.c | 32 ++++++++++++++++++++++++++------ 1 file changed, 26 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/drivers/pci/setup-bus.c =================================================================== --- linux-2.6.orig/drivers/pci/setup-bus.c +++ linux-2.6/drivers/pci/setup-bus.c @@ -299,9 +299,17 @@ static void assign_requested_resources_s bool is_ioport_res_without_bus_support = (!(bus_res_type_mask & IORESOURCE_IO)) && (res->flags & IORESOURCE_IO); + /* + * if the failed res is mmio, but bus does + * not have io port support, don't add it + */ + bool is_mmio_nonpref_res_without_bus_support = + (!(bus_res_type_mask & IORESOURCE_MEM)) && + ((res->flags & (IORESOURCE_MEM | IORESOURCE_PREFETCH)) == IORESOURCE_MEM); if (!is_rom_res_not_enabled && - !is_ioport_res_without_bus_support) + !is_ioport_res_without_bus_support && + !is_mmio_nonpref_res_without_bus_support) add_to_list(fail_head, dev_res->dev, res, 0 /* dont care */, @@ -1407,12 +1415,24 @@ static unsigned long pci_bus_res_type_ma int i; struct resource *r; unsigned long mask = 0; - unsigned long type_mask = IORESOURCE_IO | IORESOURCE_MEM | - IORESOURCE_PREFETCH; - pci_bus_for_each_resource(bus, r, i) - if (r) - mask |= r->flags & type_mask; + pci_bus_for_each_resource(bus, r, i) { + if (!r) + continue; + + if (r->flags & IORESOURCE_IO) { + mask |= IORESOURCE_IO; + continue; + } + if (r->flags & IORESOURCE_PREFETCH) { + mask |= IORESOURCE_PREFETCH; + continue; + } + if ((r->flags & (IORESOURCE_MEM | IORESOURCE_PREFETCH)) == IORESOURCE_MEM) { + mask |= IORESOURCE_MEM; /* nonpref only */ + continue; + } + } return mask; }