Patchwork [mips] split mips_reorg in pre- and post-dbr_schedule parts

login
register
mail settings
Submitter Steven Bosscher
Date May 7, 2013, 5:16 p.m.
Message ID <CABu31nNVRHOYHkELLFjNy6nuny=6VmR1wpT7WW9tW6pukOsPCw@mail.gmail.com>
Download mbox | patch
Permalink /patch/242420/
State New
Headers show

Comments

Steven Bosscher - May 7, 2013, 5:16 p.m.
On Tue, May 7, 2013 at 6:50 PM, Steve Ellcey <sellcey@imgtec.com> wrote:
> Yes, I did two builds, one with the git version just before this checkin
> and one with the checkin.  This is the patch I am refering to, it
> doesn't seem VR4130 specific.


On Tue, May 7, 2013 at 7:13 PM, Graham Stott wrote:
> Steven,
>
> The new execute mips_machine_reorrg2 part of the patch  doesn't have a return value!

Right, brilliant...  Thanks for spotting that.

Steve, can you try this, please?
Steve Ellcey - May 7, 2013, 5:29 p.m.
On Tue, 2013-05-07 at 19:16 +0200, Steven Bosscher wrote:

> On Tue, May 7, 2013 at 7:13 PM, Graham Stott wrote:
> > Steven,
> >
> > The new execute mips_machine_reorrg2 part of the patch  doesn't have a return value!
> 
> Right, brilliant...  Thanks for spotting that.
> 
> Steve, can you try this, please?
> 
> 
> Index: config/mips/mips.c
> ===================================================================
> --- config/mips/mips.c  (revision 198640)
> +++ config/mips/mips.c  (working copy)
> @@ -16388,6 +16388,7 @@ mips_machine_reorg2 (void)
>         optimizations, but this should be an extremely rare case anyhow.  */
>      mips_reorg_process_insns ();
>    mips16_split_long_branches ();
> +  return 0;
>  }
> 
>  struct rtl_opt_pass pass_mips_machine_reorg2 =

Yes, this fixed my build.

Steve Ellcey
sellcey@imgtec.com
Steven Bosscher - May 7, 2013, 7:52 p.m.
On Tue, May 7, 2013 at 7:29 PM, Steve Ellcey wrote:
> On Tue, 2013-05-07 at 19:16 +0200, Steven Bosscher wrote:
>
>> On Tue, May 7, 2013 at 7:13 PM, Graham Stott wrote:
>> > Steven,
>> >
>> > The new execute mips_machine_reorrg2 part of the patch  doesn't have a return value!
>>
>> Right, brilliant...  Thanks for spotting that.
>>
>> Steve, can you try this, please?
>>
>>
>> Index: config/mips/mips.c
>> ===================================================================
>> --- config/mips/mips.c  (revision 198640)
>> +++ config/mips/mips.c  (working copy)
>> @@ -16388,6 +16388,7 @@ mips_machine_reorg2 (void)
>>         optimizations, but this should be an extremely rare case anyhow.  */
>>      mips_reorg_process_insns ();
>>    mips16_split_long_branches ();
>> +  return 0;
>>  }
>>
>>  struct rtl_opt_pass pass_mips_machine_reorg2 =
>
> Yes, this fixed my build.

I've committed this, r198696.

Ciao!
Steven

Patch

Index: config/mips/mips.c
===================================================================
--- config/mips/mips.c  (revision 198640)
+++ config/mips/mips.c  (working copy)
@@ -16388,6 +16388,7 @@  mips_machine_reorg2 (void)
        optimizations, but this should be an extremely rare case anyhow.  */
     mips_reorg_process_insns ();
   mips16_split_long_branches ();
+  return 0;
 }

 struct rtl_opt_pass pass_mips_machine_reorg2 =